Repository navigation
Conversation
Quantize with an astype that differs from the array data type wrote data that could not be read, because the wrapper did not declare its output data type. Share the astype resolution with Delta and FixedScaleOffset. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Arrays that apply a
zarr.codecs.numcodecs.Quantizefilter whoseastypediffers from the array data type can now be read back. Previously writing succeeded, but reading failed withValueError: cannot reshape array.Agent notes
Quantizehad noresolve_metadata, so the codecs after it were told the chunk still had the array data type. Thebytescodec then encoded and decoded theastypevalues with the wrong item size.DeltaandFixedScaleOffsetalready had the sameastypelogic, copied in each class. All three now call a shared_resolve_astypehelper.numcodecs.quantize.Tests
test_generic_filter_quantizeis parametrized overastype(none, a narrower float, a wider float) and compares the read-back values with numcodecs' own encode/decode round trip, instead of a fixed tolerance.astypecases fail onmainwith "cannot reshape" and pass with this change.🤖 Generated with Claude Code