Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1367 +/- ##
===========================================
+ Coverage 7.85% 9.96% +2.10%
===========================================
Files 1125 1129 +4
Lines 112820 113548 +728
===========================================
+ Hits 8866 11316 +2450
+ Misses 103954 102232 -1722 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sneurlax
force-pushed
the
fix/1167-monero-restore-validation
branch
from
August 24, 2026 21:31
03bcbae to
4f856f1
Compare
recoverViewOnly() called exit() only when there was nothing to exit, so an about-to-be-orphaned native wallet was left auto saving, listening and syncing on a handle nothing references any more. Use the same guard the seed recover() path already has.
No field in the restore view has a validator, so the Form guard on attemptRestore() always passed and only BIP39 coins were checked at all. Gate the submit on the per field statuses instead, recomputed at submit time so a value written straight into a controller (a paste, a QR scan) is judged too. A legacy CryptoNote word is accepted by the three character prefix rule the English wordlist declares, or as a whole word from any other legacy wordlist the wallet library ships, since the library detects a seed's language itself. The phrase is hidden only once it has cleared every check. Dropping the Form wrappers reindents most of the file; read with -w. closes #1167
sneurlax
force-pushed
the
fix/1167-monero-restore-validation
branch
from
October 13, 2026 16:07
4f856f1 to
b8ccbc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1167