Skip to content

Verify committed mocks are up to date in CI #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sneurlax wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Verify committed mocks are up to date in CI #1366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,42 @@ jobs:
run: bash prebuild.sh
working-directory: scripts

- name: Verify committed generated files are up to date
run: |
# build_runner always replaces conflicting outputs, which can take
# the gitignored app config too (source_gen claims <x>.dart ->
# <x>.g.dart for every input), and ensure_test_app_config.sh's stub
# is not the configured app, so put the configured file back and
# leave the script as the fallback.
SAVED_APP_CONFIG="${RUNNER_TEMP:-/tmp}/app_config.g.dart.saved"
cp lib/app_config.g.dart "$SAVED_APP_CONFIG"
dart run build_runner build
cp "$SAVED_APP_CONFIG" lib/app_config.g.dart
bash scripts/ensure_test_app_config.sh
# hive_ce emits a registrar nothing here imports; never delete it if
# someone has committed it.
if [ -f lib/hive_registrar.g.dart ] \
&& ! git ls-files --error-unmatch lib/hive_registrar.g.dart >/dev/null 2>&1; then
rm -f lib/hive_registrar.g.dart
fi
# Committed generated files are kept dart format clean (the format
# step above checks them like any other changed file), but the
# generators format with their own dart_style, so compare formatted
# output.
git ls-files -m -o --exclude-standard -- '*.mocks.dart' '*.g.dart' \
| while read -r f; do if [ -f "$f" ]; then echo "$f"; fi; done \
| sort -u | xargs -r dart format

# build.yaml never runs build_runner, so releases are compiled from
# the committed *.g.dart; stale isar/drift output has to fail the job
# here or nothing checks it at all.
GENERATED_STATUS=$(git status --porcelain -- '*.mocks.dart' '*.g.dart')
if [ -n "$GENERATED_STATUS" ]; then
echo "$GENERATED_STATUS"
echo "::error::Committed generated files differ from build_runner output; re-run scripts/dev/build_runner.sh, dart format the changed files and commit the result."
exit 1
fi

# - name: Analyze
# run: flutter analyze
- name: Test
Expand Down
Loading