Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1364 +/- ##
===========================================
+ Coverage 7.85% 9.70% +1.84%
===========================================
Files 1125 1129 +4
Lines 112820 113551 +731
===========================================
+ Hits 8866 11020 +2154
+ Misses 103954 102531 -1423 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sneurlax
force-pushed
the
fix/building-dialog-double-pop
branch
from
August 24, 2026 21:31
ef65596 to
586a13b
Compare
Member
Author
|
The desktop half of this PR, the double-pop fix, landed in June ny levoncrypto in 1928d37. The mobile half and the cancel-inside try fix are still needed. |
The dialog's cancel button popped the navigator itself and then invoked onCancel, while callers' onCancel handlers also popped, causing a double pop. Drop the internal pop so the caller owns the dismissal, and add the missing pop to Step4View's onCancel.
Seven send flows pop the caller's route from their catch block whenever a prepareSend failure arrives after the user already dismissed the building transaction dialog. On desktop that pop empties the root navigator and blanks the window; on mobile it drops the user back to the wallet view. Hoist wasCancelled out of the try so the catch can see it, as step_4_view and the ShopinBit/CakePay send flows already do.
Hoist wasCancelled out of the try in send_from_view and the namecoin transfer/update option widgets so a prepare failure arriving after the user cancelled the building dialog no longer pops the caller route or shows a stale error dialog.
sneurlax
force-pushed
the
fix/building-dialog-double-pop
branch
from
October 13, 2026 16:07
586a13b to
b09968a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dialog's cancel button popped the navigator itself and then invoked onCancel, while callers' onCancel handlers also popped, causing a double pop. Drop the internal pop so the caller owns the dismissal, and add the missing pop to Step4View's onCancel.