Skip to content

feat: address label editing on receive page - #1362

Draft
sneurlax wants to merge 3 commits into
stagingfrom
feat/374-receive-address-label
Draft

sneurlax wants to merge 3 commits into
stagingfrom
feat/374-receive-address-label

Conversation

@sneurlax

Copy link
Copy Markdown
Member

closes #374

@codecov

codecov Bot commented May 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.67742% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.70%. Comparing base (1e2e4d9) to head (6c17e5c).
⚠️ Report is 26 commits behind head on staging.

Files with missing lines Patch % Lines
..._view/wallet_view/sub_widgets/desktop_receive.dart 0.00% 71 Missing ⚠️
lib/pages/receive_view/receive_view.dart 0.00% 23 Missing ⚠️
lib/providers/wallet/address_label_provider.dart 72.41% 8 Missing ⚠️
lib/widgets/address_label_editor.dart 78.12% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1362      +/-   ##
===========================================
+ Coverage     7.85%    9.70%   +1.84%     
===========================================
  Files         1125     1131       +6     
  Lines       112820   113616     +796     
===========================================
+ Hits          8866    11030    +2164     
+ Misses      103954   102586    -1368     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sneurlax

Copy link
Copy Markdown
Member Author

Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it

@sneurlax
sneurlax marked this pull request as draft August 20, 2026 18:58
@sneurlax
sneurlax force-pushed the feat/374-receive-address-label branch from 8954566 to 80498e0 Compare August 24, 2026 21:31
Watch an address's label row through an auto-disposed riverpod family
backed by a watched Isar query, so widgets pick up label edits made
elsewhere while they are on screen.
Show the current receiving address label with an edit button on both the
mobile and desktop receive views. Labels are read from a shared watched
provider so external changes render immediately. Writes are serialized per
editor and bound to the address the edit was started on, and a failed write
is logged and reported without blocking later edits.

Closes #374
@sneurlax
sneurlax force-pushed the feat/374-receive-address-label branch from 80498e0 to 6c17e5c Compare October 13, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit label on receiving page

1 participant