Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1273 +/- ##
===========================================
+ Coverage 7.85% 9.70% +1.84%
===========================================
Files 1125 1130 +5
Lines 112820 113590 +770
===========================================
+ Hits 8866 11019 +2153
+ Misses 103954 102571 -1383 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
…oute The overlay was pushed on the root navigator but popped from the caller's navigator, so callers inside a nested navigator (desktop) popped one of their own pages and left the overlay up. Track the pushed route and remove exactly that one.
Back up view-only data straight from secure storage, repair a missing isViewOnly flag in otherData, and refuse to create or restore a backup whose view-only data is missing, unparseable or incomplete instead of silently producing a broken wallet.
Cancellation and errors returned or threw before WakelockPlus.disable(), leaving the screen wakelock held after a failed or cancelled restore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to repro this issue:
"""
creating a Stack Wallet Backup puts you into a softlock on Linux, where clicking "Ok" on the "Stack backup saved to:" dialog throws:
"""
This should be reproduced and the conditions under which it manifests described better. I stumbled across this with a view-only Monero wallet. The current change attempts to fix an underlying race condition and touches all cryptonote wallets... just need to go thru the steps on this again to 1) reproduce it, 2) confirm the specific conditions in which it can happen, 3) verify the fix is safe (touches all wallets... no bueno...) THEN decide if the SWB process really needs fixing at all
imo it does, not just for cosmetic issues (the fade is contained to the subview/main panel on the right on desktop)