Skip to content

Refactor/card list links #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troychaplin merged 2 commits into from
Aug 4, 2026
Merged

Refactor/card list links #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6dc473
remove button from cards
troychaplin Aug 4, 2026
acac076
remove button from listing
troychaplin Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .commitlintrc.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .husky/commit-msg
View file
Open in desktop

This file was deleted.

70 changes: 10 additions & 60 deletions lib/components/Card/Card.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,10 @@ export const Primary: Story = {
render: (args) => (
<Main maxWidth="3xl">
<Card {...args}>
<Card.Header title="How to Write for the Web" />
<Card.Header title="How to Write for the Web" link="https://carleton.ca/webservices" />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst. Nulla porta posuere est, aliquam mollis mi accumsan id. Morbi mauris ex, gravida eu sodales sed, tempor vel mauris." />
</Card.Body>
<Card.Footer>
<a href="https://carleton.ca/webservices" className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
</Main>
),
Expand All @@ -53,15 +48,10 @@ export const NewsCard: Story = {
<Card.Figure>
<img src={image} alt={alt} width="400" height="300" />
</Card.Figure>
<Card.Header title={title} datePrefix="Published on" date={date} readTime="7" />
<Card.Header title={title} link={link} datePrefix="Published on" date={date} readTime="7" />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst. Nulla porta posuere est, aliquam mollis mi accumsan id. Morbi mauris ex, gravida eu sodales sed, tempor vel mauris." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand Down Expand Up @@ -93,7 +83,7 @@ export const EventCard: Story = {
<img src={image} alt={alt} width={400} height={175} />
</Card.Figure>
<Card.DateThumb startDate={startDate} endDate={endDate} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.EventMeta
startDateTime={startDate}
Expand All @@ -104,11 +94,6 @@ export const EventCard: Story = {
eventAddress={event_address}
/>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
),
)}
Expand All @@ -127,15 +112,10 @@ export const FeaturedCards: Story = {
<Card.ImageThumb>
<img src={image} alt={alt} width="200" height="133" />
</Card.ImageThumb>
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Get informed
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -151,15 +131,10 @@ export const IconCard: Story = {
{IconData.slice(0, 2).map(({ id, link, title, icon }) => (
<Card key={id} {...args}>
<Card.IconThumb icon={icon} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -174,15 +149,10 @@ export const PageCard: Story = {
<Column cols="2">
{NewsData.slice(0, 2).map(({ id, link, title, date }) => (
<Card key={id} {...args}>
<Card.Header title={title} date={date} datePrefix="Modified on " datePosition="bottom" />
<Card.Header title={title} link={link} date={date} datePrefix="Modified on " datePosition="bottom" />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst. Nulla porta posuere est, aliquam mollis mi accumsan id. Morbi mauris ex, gravida eu sodales sed, tempor vel mauris." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -200,17 +170,12 @@ export const PeopleCard: Story = {
<Card.Figure isRound>
<img src={image} alt={alt} width={280} height={280} />
</Card.Figure>
<Card.Header title={`${firstName} ${lastName}`} />
<Card.Header title={`${firstName} ${lastName}`} link={link} />
<Card.Body>
<Card.PeopleMeta jobTitle={jobTitle} phone={phone}>
<a href={`mailto:${email}`}>{email}</a>
</Card.PeopleMeta>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -228,59 +193,44 @@ export const HoursCard: Story = {
<Card.Figure>
<img src={image} alt={alt} width="400" height="300" />
</Card.Figure>
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Content>
<p className="flex items-center gap-2">
<span className="cu-card-lights cu-card-lights--green"></span>Open today until 8:00 PM
</p>
</Card.Content>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
{NewsData.slice(1, 2).map(({ id, link, title, image, alt }) => (
<Card key={id} {...args}>
<Card.Figure>
<img src={image} alt={alt} width="400" height="300" />
</Card.Figure>
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Content>
<p className="flex items-center gap-2">
<span className="cu-card-lights cu-card-lights--red"></span>Opens today at 8:00 AM
</p>
</Card.Content>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
{NewsData.slice(1, 2).map(({ id, link, title, image, alt }) => (
<Card key={id} {...args}>
<Card.Figure>
<img src={image} alt={alt} width="400" height="300" />
</Card.Figure>
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Content>
<p className="flex items-center gap-2">
<span className="cu-card-lights cu-card-lights--red"></span>Closed until tomorrow
</p>
</Card.Content>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand Down
56 changes: 8 additions & 48 deletions lib/components/Card/Examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,10 @@ export const LayoutExamples: Story = {
<Card.Figure>
<img src={image} alt={alt} width="400" height="300" />
</Card.Figure>
<Card.Header title={title} date={date} readTime="7" />
<Card.Header title={title} link={link} date={date} readTime="7" />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst. Nulla porta posuere est, aliquam mollis mi accumsan id. Morbi mauris ex, gravida eu sodales sed, tempor vel mauris." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand Down Expand Up @@ -103,7 +98,7 @@ export const LayoutExamples: Story = {
<img src={image} alt={alt} width={400} height={175} />
</Card.Figure>
<Card.DateThumb startDate={startDate} endDate={endDate} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.EventMeta
startDateTime={startDate}
Expand All @@ -114,11 +109,6 @@ export const LayoutExamples: Story = {
eventAddress={event_address}
/>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
),
)}
Expand All @@ -143,7 +133,7 @@ export const LayoutExamples: Story = {
<img src={image} alt={alt} width={400} height={175} />
</Card.Figure>
<Card.DateThumb startDate={startDate} endDate={endDate} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.EventMeta
startDateTime={startDate}
Expand All @@ -154,11 +144,6 @@ export const LayoutExamples: Story = {
eventAddress={event_address}
/>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
),
)}
Expand All @@ -180,7 +165,7 @@ export const LayoutExamples: Story = {
}) => (
<Card key={id} noImage>
<Card.DateThumb startDate={startDate} endDate={endDate} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.EventMeta
startDateTime={startDate}
Expand All @@ -191,11 +176,6 @@ export const LayoutExamples: Story = {
eventAddress={event_address}
/>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
),
)}
Expand All @@ -210,15 +190,10 @@ export const LayoutExamples: Story = {
<Card.ImageThumb>
<img src={image} alt={alt} width="200" height="133" />
</Card.ImageThumb>
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Get informed
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -228,15 +203,10 @@ export const LayoutExamples: Story = {
{IconData.slice(0, 4).map(({ id, link, title, icon }) => (
<Card key={id}>
<Card.IconThumb icon={icon} />
<Card.Header title={title} />
<Card.Header title={title} link={link} />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -255,15 +225,10 @@ export const LayoutExamples: Story = {
<Column cols="3">
{NewsData.slice(0, 3).map(({ id, link, title, date }) => (
<Card key={id}>
<Card.Header title={title} date={date} datePrefix="Modified on " datePosition="bottom" />
<Card.Header title={title} link={link} date={date} datePrefix="Modified on " datePosition="bottom" />
<Card.Body>
<Card.Excerpt text="Lorem ipsum dolor sit amet, consectetur adipiscing elit. Ut pharetra laoreet lobortis. In hac habitasse platea dictumst. Nulla porta posuere est, aliquam mollis mi accumsan id. Morbi mauris ex, gravida eu sodales sed, tempor vel mauris." />
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
Read more
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand All @@ -275,17 +240,12 @@ export const LayoutExamples: Story = {
<Card.Figure isRound>
<img src={image} alt={alt} width={280} height={280} />
</Card.Figure>
<Card.Header title={`${firstName} ${lastName}`} />
<Card.Header title={`${firstName} ${lastName}`} link={link} />
<Card.Body>
<Card.PeopleMeta jobTitle={jobTitle} phone={phone}>
<a href={`mailto:${email}`}>{email}</a>
</Card.PeopleMeta>
</Card.Body>
<Card.Footer>
<a href={link} className="cu-button cu-button--red cu-button--small">
More info
</a>
</Card.Footer>
</Card>
))}
</Column>
Expand Down
Loading
Loading