Skip to content

Fix/google api key #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bhoomi-Pipalia merged 4 commits into from
Jul 27, 2026
Merged

Fix/google api key #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d61dc1
fix: delpoy file with secrets for the google api key
Jul 23, 2026
ca1e6f7
fix: google map key in location picket
Jul 23, 2026
2912dea
add: changelog
Jul 23, 2026
a1ca011
Merge branch 'develop' into fix/google-api-key
Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
run: npm run build:storybook
env:
NODE_OPTIONS: --max_old_space_size=4096
VITE_APP_GOOGLE_MAPS_API_KEY: ${{ vars.GOOGLE_MAPS_API_KEY }}
VITE_APP_GOOGLE_MAPS_API_KEY: ${{ secrets.GOOGLE_MAPS_API_KEY }}

- name: Deploy to GitHub Pages
uses: JamesIves/github-pages-deploy-action@v4
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ Prefix the change with one of these keywords:

## [Unreleased]

### Security

- Rotated leaked Google Maps API key and moved to GitHub Secrets
- Fixed incorrect env var in `LocationPicker` component

### Added

- Circle dollar icon
Expand Down
2 changes: 1 addition & 1 deletion lib/components/LocationPicker/LocationPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function LocationPicker({ address, markerCallback }: ILocationPickerProps
const inputRef = useRef<HTMLInputElement | null>(null)

const { isLoaded } = useJsApiLoader({
googleMapsApiKey: import.meta.env.VITE_GOOGLE_MAPS_API_KEY,
googleMapsApiKey: import.meta.env.VITE_APP_GOOGLE_MAPS_API_KEY,
libraries,
})

Expand Down
Loading