Repository navigation
test: cover the event accessors no test reached -- the scroll, button… - #20
Merged
Merged
Conversation
…, absolute-motion and emulating-sequence reads on eis.Event, ei.Event.keyboard_xkb_modifiers and eis.Device.device_type/height are each a ctypes binding to a separate C symbol, where a wrong name or restype hides from reading and only shows when the library is asked, so drive them all through one socketpair negotiation and assert every value round-trips exactly
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…is the only release that stores it eis_queue_device_start_emulating_event() built the event and never copied the sequence into it, so eis_event_emulating_get_sequence() returned a zeroed struct field for every client -- upstream added the one missing assignment in libei 98cd152, released in 1.6.0 and in no earlier tag (measured 0 on 1.2.1, 1.3.901 and 1.5.0, 4242 on 1.6.0). requires_symbol is blind to this class of difference, where every version from the 1.0.0 floor up exports the symbol and only the answer changed, so conftest grew has_symbol() for a branch instead of a skip; the 0 is asserted rather than skipped, keeping the newly documented behaviour under test on an old library. Documented on the property and in the README beside touch_up_event, the other accessor that degrades rather than raising. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, absolute-motion and emulating-sequence reads on eis.Event, ei.Event.keyboard_xkb_modifiers and eis.Device.device_type/height are each a ctypes binding to a separate C symbol, where a wrong name or restype hides from reading and only shows when the library is asked, so drive them all through one socketpair negotiation and assert every value round-trips exactly