Skip to content

Fix _wait_for_signal double-removing its GLib timeout source on every… - #2

Merged
ctrondlp merged 1 commit into
mainfrom
P3-fix-timeout-source-double-remove
Sep 8, 2026
Merged

ctrondlp merged 1 commit into
mainfrom
P3-fix-timeout-source-double-remove

Conversation

@ctrondlp

@ctrondlp ctrondlp commented Sep 8, 2026

Copy link
Copy Markdown
Owner

… InputCapture timeout, which logged a spurious "Source ID not found" GLib warning -- caught live testing on the GNOME 50 box, invisible to the unit tests since the fake source_remove never modeled an already-deregistered source

… InputCapture timeout, which logged a spurious "Source ID not found" GLib warning -- caught live testing on the GNOME 50 box, invisible to the unit tests since the fake source_remove never modeled an already-deregistered source
@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f8f0c746-b641-4e9b-a79d-13f04c2c1889

📥 Commits

Reviewing files that changed from the base of the PR and between 378f253 and 0b14e92.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/libei/portal.py
  • tests/test_inputcapture.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ctrondlp
ctrondlp merged commit d04cf67 into main Sep 8, 2026
8 checks passed
@ctrondlp
ctrondlp deleted the P3-fix-timeout-source-double-remove branch September 10, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant