Repository navigation
Fall back to InputCapture v1 CreateSession when version reports 0, fi… - #1
Conversation
…xing negotiation against xdg-desktop-portal-gnome 50 -- release 0.5.1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release adds pre-v2 portal support to ChangesInput Capture Compatibility
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The legacy portal fallback and release metadata changes are ready to merge. Sequence Diagram(s)sequenceDiagram
participant InputCaptureSession
participant Portal
participant EIS
InputCaptureSession->>Portal: Get portal version
InputCaptureSession->>Portal: CreateSession with capabilities
Portal-->>InputCaptureSession: Return session handle
InputCaptureSession->>EIS: ConnectToEIS
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 63.64% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 3 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…xing negotiation against xdg-desktop-portal-gnome 50 -- release 0.5.1
Summary by CodeRabbit