Skip to content

Non-configurable install location prevents packaging on Homebrew #12

Closed

Description

@nwhetsell

At commit 028c6e8, the value of PLUGIN_INSTALL_DIR (which determines where plug-ins are installed) was hard-coded to $HOME/Library/csound/<csound_version>/plugins64 on macOS when Csound uses double-precision samples. This means that plug-ins can’t be installed on macOS using Homebrew, as Homebrew does not permit installing files at that location. Not building Csound plug-ins using Homebrew isn’t really an option, as some Homebrew users rely on these plug-ins being there: https://listserv.heanet.ie/cgi-bin/wa?A1=ind2107&L=CSOUND-DEV#18. Please support a configurable PLUGIN_INSTALL_DIR.

Activity

  1. vlazzarini commented on Feb 2, 2022

    @vlazzarini
    Member

    There is no current maintainer for this repository, but we are happy to take a PR on this. In any case, the default location should be $HOME/Library/csound/<csound_version>/plugins64, because that is the default CS_PLUGIN_DIR that Csound uses.

  2. dvzrv commented on Feb 4, 2022

    @dvzrv

    @nwhetsell this is not really fixed, as there is no new release yet and downstreams can not package this software.

    @vlazzarini A patch level release would be awesome! Thanks! :)

  3. nwhetsell commented on Feb 4, 2022

    @nwhetsell
    ContributorAuthor

    @dvzrv I’ll leave reopening this issue to the repository owners; as far as Homebrew is concerned, this issue is resolved. Csound plugins are managed using a resource block (here), for which no release is necessary.

  4. vlazzarini commented on Feb 4, 2022

    @vlazzarini
    Member

    @dvzrv there's an open issue with hdr5 opcodes, which is been looked at by John. I can do a source code release once that's cleared.

  5. vlazzarini commented on Feb 8, 2022

    @vlazzarini
    Member

    @dvzrv release is done now that the hdrf5 opcodes were fixed

    https://github.com/csound/plugins/releases/tag/1.0.2

  6. nwhetsell commented on Oct 29, 2026

    @nwhetsell
    ContributorAuthor

    PLUGIN_INSTALL_DIR regressed to being non-configurable again at 76e5d49. I previously fixed this in PR #13.

    PLUGIN_INSTALL_DIR should be set as a cache entry so that packagers can package these plug-ins.

  7. vlazzarini commented on Oct 29, 2026

    @vlazzarini
    Member

    Can you make a PR against develop with what you need?

  8. kunstmusik commented on Oct 29, 2026

    @kunstmusik
    Member

    I've got a fix, setting up PR now.

  9. kunstmusik commented on Oct 29, 2026

    @kunstmusik
    Member

    @nwhetsell Could you check #66 and verify it's the right fix for the issue?

    For reference, AI diagnosis as to what happened is as follows:

    Diagnosis

    1. Initial Fix (PR Set PLUGIN_INSTALL_DIR as cache entry and fix building FluidSynth opcodes on macOS #13): On Feb 2, 2022, commit 33c7db3 (merged in 9b9911b via PR Set PLUGIN_INSTALL_DIR as cache entry and fix building FluidSynth opcodes on macOS #13) updated CMakeLists.txt to set PLUGIN_INSTALL_DIR on macOS (APPLE) as a CMake cache entry (CACHE PATH "Plugin install path"), allowing packagers such as Homebrew to override -DPLUGIN_INSTALL_DIR=....
    2. Root Cause of Regression (PR MSVC fixes and VCPKG integration #10 rebase): Commit 76e5d49 (Fix PLUGIN_INSTALL_DIR for windows) was originally authored on Sep 13, 2021—before PR Set PLUGIN_INSTALL_DIR as cache entry and fix building FluidSynth opcodes on macOS #13 existed—as part of the long-lived feature/vcpkgBuild branch (PR MSVC fixes and VCPKG integration #10). When that branch was rebased onto develop on June 21, 2023 and merged on July 2, 2023 (4cbd806), the rebase conflict resolution replaced the entire if(USE_DOUBLE) ... else() ... endif() block in CMakeLists.txt with the Sep 2021 version, dropping CACHE PATH "Plugin install path" and reverting set(PLUGIN_INSTALL_DIR ...) back to a normal (non-cache) variable that overrides command-line -DPLUGIN_INSTALL_DIR=... definitions.
    3. Propagation to 7.x / Root: When the 7.x directory was created from 6.x (d31b575) and later flattened to the repository root (cb0005e), it inherited the regressed non-cache set(PLUGIN_INSTALL_DIR ...) statements.
  10. nwhetsell commented on Oct 29, 2026

    @nwhetsell
    ContributorAuthor

    @kunstmusik Looks good to me.

  11. kunstmusik commented on Oct 29, 2026

    @kunstmusik
    Member

    @nwhetsell Thanks for reporting and verifying! WIll merge that PR and close this issue.

  12. added a commit that references this issue on Nov 6, 2026
    94d6dd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions