Repository navigation
fix: a blocking question of 'none' with a reason counts as none (v2.27.1) - #93
Merged
Merged
Conversation
Questions for you의 none 뒤에 설명이 붙으면(none (...), None — ..., None.) intent가 NEEDS-HUMAN으로 남던 문제. none 다음 공백·구두점·괄호를 허용하고, 다른 값은 그대로 열린 질문이다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.27.1: A blocking question of "none" with a reason counts as none
Problem
The intent parser treated a line under Questions for you (or Blocking questions) as answered only when it was exactly
none. An intent that wrote- none (all six areas clear; nothing open)madesdlc.sh statusandnextreport the intent NEEDS-HUMAN with that text as the open question, andapprove intentrefused it, although nothing was open.Changes
sdlc.sh: a question line reads as none when it isnone, any case, alone or followed by a space, tab,.,,,;,:or(and any explanation, e.g.none (all areas clear),None — settled,None.. Any other value is still an open question;noneinside a longer word (nonexistent) is too.none (reason),None — reasonandNone.are not open questions;Which output format?is.