Repository navigation
fix(todo): 펼침면에서 글자 사이가 벌어지던 양쪽 맞춤 제거 (v2.25.1) - #90
Merged
Merged
Conversation
넓은 창의 두 쪽 펼침면은 egui columns로 만드는데, egui는 각 열을 양쪽 맞춤(top_down_justified) 배치로 만들고 Label은 그 배치를 따라 줄바꿈된 글을 양쪽 맞춤한다. 그래서 두 쪽의 글이 단어 사이가 늘어나고, 긴 토큰 앞 줄은 '원 문 유 지 · 별 도 U T F - 8'처럼 글자마다 벌어졌다. 이제 각 쪽의 내용을 왼쪽 정렬 top_down 배치 안에 그려 한 쪽 화면처럼 오른쪽이 들쭉날쭉하게 읽힌다. 질문·AI 권장 상자와 입력란은 그대로 쪽 너비를 채우고, 쪽 위에 바로 놓인 버튼(설명 붙은 선택지·승인·자가 조치)은 한 쪽 화면처럼 글자 너비가 된다. 목록 탭은 한 줄 행이 잘림 처리라 영향이 없어 그대로 둔다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.25.1: The two-page spread reads ragged-right again
To-do app (
todo/app) only. The web page, the TUI, the server andtodo.mdare unchanged.Problem
On a wide window (960 points or more) a decision opens as a two-page spread, built from egui columns. egui lays each column out justified, and a wrapped label in a justified layout is fully justified: word gaps stretched to the page edge, and a line followed by a long unbreakable token was spread letter by letter (e.g. "원 문 유 지 · 별 도 U T F - 8 서 명 경 로"). The single page on a narrow window was not affected.
Changes
After updating
Rebuild the app: run
todo/app/install-macos.shagain (macOS), orcargo build --releaseintodo/app.Verification
Run in
todo/appon macOS:cargo test: 7 passed, 0 failed.cargo build --release: no warnings.cargo clippy --release: one warning, the existingnonminimal_bool("this boolean expression can be simplified"); nothing new.Ui::columns_dynbuilds each column withLayout::top_down_justified(Align::LEFT),Labelcopieshorizontal_justify()intoLayoutJob::justify, and epaint justifies every wrapped row except the last. InsideLayout::top_down(Align::LEFT)horizontal_justify()is false. Truncated labels (the list rows) setjustify = falsethemselves, which is why the list tabs are left as they are.