Repository navigation
playwright-test: add an upload input that keeps a green run's screenshots - #79
Merged
Merged
Conversation
The playwright-report artifact (the report and test-results/, screenshots included) was uploaded only on failure, so a passing run kept no screenshots to review. A new `upload` input, default `failure`, makes the upload step run on `failure() || inputs.upload == 'always'`. Every existing caller keeps the failure-only behaviour unchanged. A value other than `failure` or `always` fails the lockstep job before any pod is spent, so a typo cannot skip the artifact. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README gets a short note on the input.
Evidence
testjob and uploads no artifact. Its screenshots exist only on the runner, because the upload step isif: failure().After: the same caller with
upload: alwayson the release that carries this change. The link goes in a follow-up comment on this PR once that run is green.actionlint1.7.12 (the versionselftestuses) passes onplaywright-test.yml, and on every other workflow in this repo.Merge Danger
Door: two-way for this PR. It adds an input whose default keeps today's behaviour, so a revert restores the old workflow exactly. Once a release tag exists, it is one-way: released tags never move, and a bad one is superseded by a patch.
The release that follows this PR (v1.12.0) is cut from
main, which already carries #77. That bumps the Playwright image default tov1.64.0-noble. The image is mirrored on ghcr and exists upstream on MCR. Any caller that moves to v1.12.0 without also moving its@playwright/testpin to 1.64.0 failslockstep, as MSD#41 does. The README already states that rule.Blast radius: every caller of
playwright-test.yml, but only through the new input. Existing callers that do not setuploadsee no change, anduploadcannot be set by accident, because its default isfailure. Callers that adopt v1.12.0 also inherit the v1.64.0 default described above.🤖 Generated with Claude Code