Repository navigation
Conversation
strcasestr() is a GNU extension that MinGW doesn't provide causing the win32 build to fail.
Contributor
|
nice find, as you have a working windows development environment could you please check the windows related part of my pr #442 if the NEWS and other files have or should have the .txt extension or not? thanks |
Owner
|
Thanks for the patch. These changes were also included in #449, except the removal of #define _GNU_SOURCE, which I have removed manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
makeinwin32/fails under MSYS2/MinGW64:strcasestr()is a GNU extension and isn't in the MinGW C runtime.gtk-rot-ctrl.chas the same call.Fix
gtk-rig-ctrl.candgtk-rot-ctrl.cnow use the existing portablegpredict_strcasestr()fromgpredict-utils.c.#define _GNU_SOURCEand its comments from those two files and fromgtk-sat-selector.c(which alread uses the utility function) since they were only needed forstrcasestr.