Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ teardown, IR writes, Clang lowering and linking. See
[the build benchmark tools](tools/benchmarks/README.md) for repeatable Redis/Git
comparisons and interpretation of nested stage and Clang trace totals.

For record-member scaling and a separate Clang comparison to LLVM IR, see the
[2026-10-18 frontend measurements](tools/benchmarks/results/linux-x86_64-2026-10-18-record-members.md).
These measurements do not replace the clean-build timings below.

## Measured Linux build times

### Native preprocessing and LLVM tools backend (2026-10-17)
Expand Down
55 changes: 55 additions & 0 deletions examples/profile_record_members.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
//! Measure tokenization, AST construction and teardown for record-heavy inputs.

use dynamite_compiler::{
ast::{AstBuilder, AstBuilderImpl},
error::ErrorPrinter,
tokenizer::Tokenizer,
};
use std::{hint::black_box, time::Instant};

fn frontend(code: &str) {
let logger = ErrorPrinter::new(code);
let tokens = Tokenizer::tokenize(code, false).unwrap();
let mut builder = AstBuilderImpl::new(&logger, &tokens);
black_box(builder.build(false));
}

fn median_ms(code: &str, iterations: usize) -> f64 {
frontend(code);
let mut samples = Vec::with_capacity(9);
for _ in 0..9 {
let start = Instant::now();
for _ in 0..iterations {
frontend(black_box(code));
}
samples.push(start.elapsed().as_secs_f64() * 1_000.0 / iterations as f64);
}
samples.sort_by(f64::total_cmp);
samples[samples.len() / 2]
}

fn main() {
println!("workload\ttokenize_parse_drop_ms");
for members in [128, 512, 2048] {
let fields = (0..members)
.map(|index| format!("int field{index};"))
.collect::<String>();
let last = members - 1;
let code = format!(
"struct Wide {{{fields}}};int main(void){{struct Wide value;value.field{last}=7;return value.field{last};}}"
);
println!("wide-{members}\t{:.4}", median_ms(&code, 5));
}
let fields = (0..512)
.map(|index| format!("int field{index};"))
.collect::<String>();
let values = vec!["1"; 512].join(",");
let code = format!(
"struct Wide {{{fields}}};int main(void){{struct Wide value={{{values}}};return value.field511;}}"
);
println!("initialized-512\t{:.4}", median_ms(&code, 5));
for path in std::env::args().skip(1) {
let code = std::fs::read_to_string(&path).unwrap();
println!("{path}\t{:.4}", median_ms(&code, 1));
}
}
12 changes: 9 additions & 3 deletions src/ast/initializers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ impl AstBuilderImpl<'_> {
Some(child.as_ref().clone())
}
Type::Struct(st) => st
.members()
.definition()
.borrow()
.members
.get(index)
.filter(|member| !matches!(member.ty.unqualified(), Type::Arr(_, None)))
.map(|member| member.ty.clone()),
Expand Down Expand Up @@ -447,7 +449,9 @@ impl AstBuilderImpl<'_> {
.collect(),
),
Type::Struct(ty) => Some(
ty.members()
ty.definition()
.borrow()
.members
.iter()
.filter(|member| !matches!(member.ty.unqualified(), Type::Arr(_, None)))
.map(|member| Self::member_node(node.clone(), member, token))
Expand Down Expand Up @@ -505,7 +509,9 @@ impl AstBuilderImpl<'_> {
vec![]
} else {
record
.members()
.definition()
.borrow()
.members
.iter()
.filter(|member| member.bit_field.is_none())
.map(|member| (member.offset, member.offset + member.ty.size_of()))
Expand Down
5 changes: 4 additions & 1 deletion src/ast/transparent_union.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ impl AstBuilderImpl<'_> {
);
return;
};
let members = record.members();
let definition = record.definition();
let definition = definition.borrow();
let members = &definition.members;
let valid = record.definition().borrow().is_union
&& ty.is_complete_object()
&& members.first().is_some_and(|first| {
Expand All @@ -48,6 +50,7 @@ impl AstBuilderImpl<'_> {
&& Self::transparent_mode(&member.ty) == mode
})
});
drop(definition);
if !valid {
self.error_logger.print_error_position(token.pos, "transparent unions require scalar members with matching calling representations and layout");
}
Expand Down
36 changes: 11 additions & 25 deletions src/ast/type_parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ impl AstBuilderImpl<'_> {
.print_error_position(token.pos, "struct tag is already defined");
}
let mut members: Vec<StructMember> = vec![];
let mut member_names = std::collections::BTreeSet::new();
let mut size = 0usize;
let mut bit_address = 0usize;
let mut has_bit_fields = false;
Expand Down Expand Up @@ -753,35 +754,20 @@ impl AstBuilderImpl<'_> {
};
if name.is_some() || matches!(member_type.unqualified(), Type::Struct(_)) {
let anonymous = name.is_none();
let visible = if anonymous {
// Index visible names once; avoid rescanning all preceding members.
let mut insert_name = |name: &str| {
if !member_names.insert(name.to_owned()) {
self.error_logger
.print_error_position(position.pos, "duplicate struct member");
}
};
if anonymous {
let Type::Struct(child) = member_type.unqualified() else {
unreachable!()
};
child
.visible_members()
.into_iter()
.map(|(name, _)| name)
.collect::<Vec<_>>()
child.for_each_visible_member(&mut |name, _| insert_name(name));
} else {
vec![name.as_ref().unwrap().s_value.to_string()]
};
for existing in &members {
let existing_names = if existing.anonymous {
let Type::Struct(child) = existing.ty.unqualified() else {
unreachable!()
};
child
.visible_members()
.into_iter()
.map(|(name, _)| name)
.collect::<Vec<_>>()
} else {
vec![existing.name.clone()]
};
if visible.iter().any(|name| existing_names.contains(name)) {
self.error_logger
.print_error_position(position.pos, "duplicate struct member");
}
insert_name(&name.as_ref().unwrap().s_value);
}
members.push(StructMember {
name: name.map_or_else(
Expand Down
4 changes: 3 additions & 1 deletion src/ast/validation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,9 @@ impl AstBuilderImpl<'_> {
self.validate_global_initializer(&ty.member(*index).ty, value, token);
}
(Type::Struct(ty), GlobalVariableData::Arr(elements)) => {
let members = ty.members();
let definition = ty.definition();
let definition = definition.borrow();
let members = &definition.members;
let capacity = if ty.definition().borrow().is_union {
1
} else {
Expand Down
70 changes: 42 additions & 28 deletions src/ctype/records.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,45 +27,59 @@ impl StructType {
self.definition().borrow().members[index].clone()
}
pub fn visible_members(&self) -> Vec<(String, Vec<usize>)> {
self.members()
.iter()
.enumerate()
.flat_map(|(index, member)| {
let mut members = vec![];
self.for_each_visible_member(&mut |name, path| {
members.push((name.to_owned(), path.to_vec()));
});
members
}

pub(crate) fn for_each_visible_member(&self, operation: &mut impl FnMut(&str, &[usize])) {
fn visit(
record: &StructType,
path: &mut Vec<usize>,
operation: &mut impl FnMut(&str, &[usize]),
) {
let definition = record.definition();
let definition = definition.borrow();
for (index, member) in definition.members.iter().enumerate() {
path.push(index);
if member.anonymous {
let Type::Struct(child) = member.ty.unqualified() else {
unreachable!()
};
child
.visible_members()
.into_iter()
.map(|(name, mut path)| {
path.insert(0, index);
(name, path)
})
.collect()
visit(child, path, operation);
} else {
vec![(member.name.clone(), vec![index])]
operation(&member.name, path);
}
})
.collect()
path.pop();
}
}
visit(self, &mut vec![], operation);
}

pub fn member_path(&self, name: &str) -> Option<Vec<usize>> {
let definition = self.definition();
let definition = definition.borrow();
for (index, member) in definition.members.iter().enumerate() {
if member.anonymous {
let Type::Struct(child) = member.ty.unqualified() else {
unreachable!()
};
if let Some(mut path) = child.member_path(name) {
path.insert(0, index);
return Some(path);
fn find(record: &StructType, name: &str, path: &mut Vec<usize>) -> bool {
let definition = record.definition();
let definition = definition.borrow();
for (index, member) in definition.members.iter().enumerate() {
path.push(index);
if member.anonymous {
let Type::Struct(child) = member.ty.unqualified() else {
unreachable!()
};
if find(child, name, path) {
return true;
}
} else if member.name == name {
return true;
}
} else if member.name == name {
return Some(vec![index]);
path.pop();
}
false
}
None
let mut path = vec![];
find(self, name, &mut path).then_some(path)
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/generator/globals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ where
let mut lines = vec![];
let mut end = 0;
for (i, member) in struct_type
.members()
.definition()
.borrow()
.members
.iter()
.take(if struct_type.definition().borrow().is_union {
1
Expand Down
8 changes: 6 additions & 2 deletions src/generator/llvm/generator/globals.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ impl IrGenerator<'_> {
record.definition().borrow().packing.is_some()
|| ty.contains_typedef_alignment()
|| record
.members()
.definition()
.borrow()
.members
.iter()
.any(|member| Self::contains_packed_record(&member.ty))
}
Expand Down Expand Up @@ -303,7 +305,9 @@ impl IrGenerator<'_> {
if let Some(GlobalVariableData::Arr(elements)) = data {
let mut fields = vec![];
let mut offset = 0usize;
for (index, member) in struct_type.members().iter().enumerate() {
for (index, member) in
struct_type.definition().borrow().members.iter().enumerate()
{
let aligned_offset =
offset.div_ceil(member.ty.align_of()) * member.ty.align_of();
if member.offset > aligned_offset {
Expand Down
2 changes: 1 addition & 1 deletion src/global.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub fn initializer_bytes(
} else {
0
};
for (index, member) in st.members().iter().enumerate() {
for (index, member) in st.definition().borrow().members.iter().enumerate() {
if union && index != selected {
continue;
}
Expand Down
8 changes: 8 additions & 0 deletions tests/cases/expressions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,20 @@ fn anonymous_aggregate_members(output_option: &str) {
#[test_matrix([
"struct Duplicate{int x;union{int x;};};int main(){return 0;}",
"struct Nested{struct{int x;};union{int x;};};int main(){return 0;}",
"struct Deep{union{struct{int x;};};int x;};int main(){return 0;}",
"struct Deep{int x;union{struct{int x;};};};int main(){return 0;}",
"struct Qualified{struct{int x;};};int main(){const struct Qualified s={{1}};s.x=2;return 0;}",
])]
fn rejects_invalid_anonymous_aggregate_members(code: &str) {
assert_frontend_error(code);
}

#[test_matrix(["asm", "llvm"])]
fn named_members_keep_nested_names_in_their_own_scope(output_option: &str) {
let code = "struct S{struct{int value;} named;union{struct{int value;};};};struct S g={.named={3},.value=7};int main(){struct S s={.named={5},.value=9};return g.named.value!=3 || g.value!=7 || s.named.value!=5 || s.value!=9;}";
assert_eq!(compile_and_run(code, output_option).status.code(), Some(0));
}

#[test_matrix(["asm", "llvm"])]
fn glibc_integer_word_mode(output_option: &str) {
let code = "typedef int word __attribute__((__mode__(__word__)));typedef unsigned int uword __attribute__((mode(word)));struct Counter{__extension__ unsigned long long value;};int main(){word x=-1;uword y=0xffffffffffffffffUL;struct Counter c={7};return sizeof(word)!=8 || sizeof(uword)!=8 || x>=0 || y!=0xffffffffffffffffUL || c.value!=7;}";
Expand Down
9 changes: 9 additions & 0 deletions tools/benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,3 +103,12 @@ For the experimental LLVM tools backend, set `DYNAMITE_BACKEND=llvm` and select
matching `DYNAMITE_LLC`, `DYNAMITE_OPT`, and `DYNAMITE_LLD` executables. Use
`--no-trace`, since Clang time-trace options are unsupported on that path.
Preprocessing always uses Dynamite's native implementation.

## Record-member scaling

Build and run `cargo run --release --example profile_record_members -- INPUT.i ...`
to measure tokenization, AST construction and teardown for synthetic wide records,
a fully initialized record, and optional already-preprocessed application inputs.
The example prints warm-run medians and excludes file reads and IR generation.
See the [record-member measurements](results/linux-x86_64-2026-10-18-record-members.md)
for the baseline comparison, Clang CLI timings and measurement boundaries.
Loading
Loading