Repository navigation
refactor: share native data emission and AST traversal - #214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native global-data generation was duplicated across the x86_64 and AArch64 backends, and structural AST walks repeated the same child-field lists in multiple passes. Share data-directive emission while retaining the native Assembly types and each backend's symbol formatting. Add borrowed direct-child iterators and use them for the matching full structural traversals, preserving child order and each pass's pre/post-order behavior.
Validation: Rust 1.86 formatting and strict all-target/all-feature Clippy; full all-feature tests (51 unit, 2,101 integration, 1 doc passed; 2 optional tests ignored). Read-only sub-agent self-review completed; the documentation placement finding was fixed and the final diff was re-reviewed with no outstanding findings. macOS/AArch64 execution is not available locally.