Skip to content

refactor: share native data emission and AST traversal - #214

Merged
cruskell merged 1 commit into
mainfrom
codex/share-data-emission-and-ast-traversal
Oct 18, 2026
Merged

cruskell merged 1 commit into
mainfrom
codex/share-data-emission-and-ast-traversal

Conversation

@cruskell

Copy link
Copy Markdown
Owner

Native global-data generation was duplicated across the x86_64 and AArch64 backends, and structural AST walks repeated the same child-field lists in multiple passes. Share data-directive emission while retaining the native Assembly types and each backend's symbol formatting. Add borrowed direct-child iterators and use them for the matching full structural traversals, preserving child order and each pass's pre/post-order behavior.

Validation: Rust 1.86 formatting and strict all-target/all-feature Clippy; full all-feature tests (51 unit, 2,101 integration, 1 doc passed; 2 optional tests ignored). Read-only sub-agent self-review completed; the documentation placement finding was fixed and the final diff was re-reviewed with no outstanding findings. macOS/AArch64 execution is not available locally.

@cruskell
cruskell merged commit cebd56b into main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant