Repository navigation
refactor: group compiler data model members by responsibility - #212
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiler data declarations mixed newer features into unrelated field/variant groups. Organize 21 enum/struct declarations by responsibility: AST values/operators/control flow/builtins; scalar/derived/wrapper types; parser/preprocessor state; function/object metadata; backend state and driver options. Group instruction mnemonics by operation and registers by register family and subregisters.
Preserve every member name, type, visibility and default attribute. Constructor expressions, match arms, ABI register arrays and all code outside the declarations are unchanged. Rust's implicit enum discriminants and derived Debug field ordering follow the new declaration order; these types have no repr/serialization/numeric-tag use in the repository. C source record layouts and enum values are still computed by the unchanged parser/type operations.
Validation on Linux x86_64 with Rust 1.86: make lint and cargo test --all-features passed (51 unit, 2,101 integration and one doc test; two optional LLVM backend tests ignored locally). Compared all declaration member/type/attribute sets and checked all code outside them is unchanged. Size/alignment measurements match for Node, NodeType, Type, StructDefinition, StructMember, Token, Func, GlobalVariable and AstBuilderImpl. git diff --check passed. macOS/AArch64 execution was not run locally.