Repository navigation
refactor: organize driver modules and definition order - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organize the C build driver as a standard directory binary with main.rs, argument parsing in arguments.rs, and separate GNU/Darwin linker modules beneath llvm_tools.rs. Preserve all Cargo target names/kinds/editions, backend selection, compiler/linker option ordering and executable behavior; remove the explicit llvm_tools path attribute and document the layout.
Also finish definition-order cleanup: place the toolchain module declaration and shared generator imports with their peers, group shared ABI data with target enums, put public parser data before private declarator helpers, and move the inline assembly renderer after the node representation/operations. All 19 driver method bodies and the relocated renderer/declarator resolver are unchanged.
Validation: Rust 1.86 make lint and cargo test --all-features passed (51 unit, 2,101 integration and one doc test; two optional LLVM toolchain tests ignored locally). Cargo metadata target comparison and moved-body checks passed, as did git diff --check. macOS/AArch64 execution was not run locally.