Repository navigation
refactor: split target generator responsibilities - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate aggregate ABI handling, global initializers, atomic operations and inline assembly into standard generator child modules for x86_64, AArch64 and LLVM. Keep generator entry points, state ownership and core node dispatch in each generator.rs, using the same responsibility names across targets without merging target-specific implementations. Document the layout.
All 46 moved method bodies match their originals byte-for-byte. New methods are scoped to their parent generator; instruction representations, register choices, ABI rules, diagnostics and output formatting are preserved. Move the LLVM unit test's data import into its test module.
Validation: Rust 1.86 make lint and cargo test --all-features passed (51 unit, 2,101 integration and one doc test; two optional LLVM toolchain tests ignored locally). All three backend modules compile and the moved-body comparison and git diff --check pass. Runtime validation was on Linux x86_64; macOS/AArch64 execution was not run locally.