Skip to content

Add clientPort field to payment requests #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byofficial wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add clientPort field to payment requests #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions craftgate/request/create_apm_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ def __init__(
buyer_member_id: Optional[int] = None,
apm_order_id: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
items: Optional[List[PaymentItem]] = None
) -> None:
self.apm_type = apm_type
Expand All @@ -35,4 +36,5 @@ def __init__(
self.buyer_member_id = buyer_member_id
self.apm_order_id = apm_order_id
self.client_ip = client_ip
self.client_port = client_port
self.items = items
2 changes: 2 additions & 0 deletions craftgate/request/create_deposit_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ def __init__(
callback_url: Optional[str] = None,
pos_alias: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
card: Optional[Card] = None,
routing_options: Optional[RoutingOptions] = None
) -> None:
Expand All @@ -27,5 +28,6 @@ def __init__(
self.callback_url = callback_url
self.pos_alias = pos_alias
self.client_ip = client_ip
self.client_port = client_port
self.card = card
self.routing_options = routing_options
4 changes: 3 additions & 1 deletion craftgate/request/create_fund_transfer_deposit_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ def __init__(
price: Optional[Decimal] = None,
buyer_member_id: Optional[int] = None,
conversation_id: Optional[str] = None,
client_ip: Optional[str] = None
client_ip: Optional[str] = None,
client_port: Optional[int] = None
) -> None:
self.price = price
self.buyer_member_id = buyer_member_id
self.conversation_id = conversation_id
self.client_ip = client_ip
self.client_port = client_port
2 changes: 2 additions & 0 deletions craftgate/request/create_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def __init__(
conversation_id: Optional[str] = None,
external_id: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
payment_phase: PaymentPhase = PaymentPhase.AUTH,
payment_channel: Optional[str] = None,
buyer_member_id: Optional[int] = None,
Expand All @@ -45,6 +46,7 @@ def __init__(
self.conversation_id = conversation_id
self.external_id = external_id
self.client_ip = client_ip
self.client_port = client_port
self.payment_phase = payment_phase
self.payment_channel = payment_channel
self.buyer_member_id = buyer_member_id
Expand Down
2 changes: 2 additions & 0 deletions craftgate/request/dto/masterpass_create_payment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def __init__(
conversation_id: Optional[str] = None,
external_id: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
payment_phase: PaymentPhase = PaymentPhase.AUTH,
payment_channel: Optional[str] = None,
buyer_member_id: Optional[int] = None,
Expand All @@ -35,6 +36,7 @@ def __init__(
self.conversation_id = conversation_id
self.external_id = external_id
self.client_ip = client_ip
self.client_port = client_port
self.payment_phase = payment_phase
self.payment_channel = payment_channel
self.buyer_member_id = buyer_member_id
Expand Down
4 changes: 3 additions & 1 deletion craftgate/request/init_apm_deposit_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ def __init__(
apm_order_id: Optional[str] = None,
apm_user_identity: Optional[str] = None,
additional_params: Optional[Dict[str, Any]] = None,
client_ip: Optional[str] = None
client_ip: Optional[str] = None,
client_port: Optional[int] = None
) -> None:
self.apm_type = apm_type
self.merchant_apm_id = merchant_apm_id
Expand All @@ -36,3 +37,4 @@ def __init__(
self.apm_user_identity = apm_user_identity
self.additional_params = additional_params
self.client_ip = client_ip
self.client_port = client_port
2 changes: 2 additions & 0 deletions craftgate/request/init_apm_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def __init__(
apm_user_identity: Optional[str] = None,
additional_params: Optional[Dict[str, str]] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
items: Optional[List[PaymentItem]] = None
) -> None:
self.apm_type = apm_type
Expand All @@ -43,4 +44,5 @@ def __init__(
self.apm_user_identity = apm_user_identity
self.additional_params = additional_params
self.client_ip = client_ip
self.client_port = client_port
self.items = items
2 changes: 2 additions & 0 deletions craftgate/request/init_garanti_pay_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ def __init__(
external_id: Optional[str] = None,
callback_url: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
payment_channel: Optional[str] = None,
buyer_member_id: Optional[int] = None,
bank_order_id: Optional[str] = None,
Expand All @@ -36,6 +37,7 @@ def __init__(
self.external_id = external_id
self.callback_url = callback_url
self.client_ip = client_ip
self.client_port = client_port
self.payment_channel = payment_channel
self.buyer_member_id = buyer_member_id
self.bank_order_id = bank_order_id
Expand Down
2 changes: 2 additions & 0 deletions craftgate/request/init_pos_apm_payment_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def __init__(
buyer_member_id: Optional[int] = None,
bank_order_id: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
items: Optional[List[PaymentItem]] = None,
additional_params: Optional[Dict[str, Any]] = None,
installments: Optional[List[PosApmInstallment]] = None,
Expand All @@ -46,6 +47,7 @@ def __init__(
self.buyer_member_id = buyer_member_id
self.bank_order_id = bank_order_id
self.client_ip = client_ip
self.client_port = client_port
self.items = items or []
self.additional_params = additional_params or {}
self.installments = installments or []
Expand Down
2 changes: 2 additions & 0 deletions craftgate/request/retrieve_loyalties_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def __init__(
card_token: Optional[str] = None,
secure_fields_token: Optional[str] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
conversation_id: Optional[str] = None,
fraud_params: Optional[FraudCheckParameters] = None,
) -> None:
Expand All @@ -26,5 +27,6 @@ def __init__(
self.card_token = card_token
self.secure_fields_token = secure_fields_token
self.client_ip = client_ip
self.client_port = client_port
self.conversation_id = conversation_id
self.fraud_params = fraud_params
2 changes: 2 additions & 0 deletions craftgate/request/verify_card_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def __init__(
verification_price: Optional[Decimal] = None,
currency: Optional[Currency] = None,
client_ip: Optional[str] = None,
client_port: Optional[int] = None,
conversation_id: Optional[str] = None,
callback_url: Optional[str] = None
) -> None:
Expand All @@ -23,5 +24,6 @@ def __init__(
self.verification_price = verification_price
self.currency = currency
self.client_ip = client_ip
self.client_port = client_port
self.conversation_id = conversation_id
self.callback_url = callback_url
3 changes: 3 additions & 0 deletions tests/test_payment_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ def test_init_apm_deposit_payment(self):
req.external_id = "optional-externalId"
req.callback_url = "https://www.your-website.com/craftgate-apm-callback"
req.client_ip = "127.0.0.1"
req.client_port = 51520

resp = self.payment.init_apm_deposit_payment(req)
print(resp)
Expand Down Expand Up @@ -1375,6 +1376,7 @@ def test_retrieve_loyalties(self):
req.cvc = "000"

req.client_ip = "127.0.0.1"
req.client_port = 51520
req.conversation_id = "456d1297-908e-4bd6-a13b-4be31a6e47d5"
req.fraud_params = FraudCheckParameters()
req.fraud_params.buyer_email = "buyer@email.com"
Expand Down Expand Up @@ -1810,6 +1812,7 @@ def test_verify_card_with_3ds(self):
req.verification_price = Decimal("10")
req.currency = Currency.TRY
req.client_ip = "127.0.0.1"
req.client_port = 51520

resp = self.payment.verify_card(req)
print(resp)
Expand Down
Loading