Skip to content

chore(deps): bump axios from 0.33.0 to 0.34.0 (GHSA-x97p-jq2g-jp4f) - #343

Closed
Kolahzary wants to merge 1 commit into
craftgate:masterfrom
beijeco:chore/bump-axios-0.34.0
Closed

Kolahzary wants to merge 1 commit into
craftgate:masterfrom
beijeco:chore/bump-axios-0.34.0

Conversation

@Kolahzary

Copy link
Copy Markdown

Closes #342

Summary

Bumps the exact axios pin from 0.33.0 to 0.34.0 to resolve GHSA-x97p-jq2g-jp4f (high severity, a prototype-pollution gadget in axios toFormData). The fix is in 0.34.0, on the same 0.x line, so this stays on 0.x and does not move to axios 1.x.

Because the dependency is pinned exactly, users of @craftgate/craftgate can't pick up the fix until the pin changes. Security scanners (npm audit, Dependabot, Snyk) currently flag every project that installs this package.

Changes

  • package.json: "axios": "0.33.0" → "axios": "0.34.0". It is still an exact pin, and no other dependencies changed.

Impact

axios is the only runtime dependency. It is used in one place, src/lib/HttpClient.ts (axios.create({ baseURL })). The client never builds FormData or multipart bodies, so the bump doesn't change behaviour.

Testing

  • npm run build: passes
  • npm test: 77 passed, 0 failed
  • npm run lint:check: passes
  • npm ls axios: resolves only axios@0.34.0, including the copy that axios-mock-adapter uses

Copilot AI balanced review requested due to automatic review settings October 1, 2026 06:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kadirtaskiran

Copy link
Copy Markdown
Member

@Kolahzary Thank you for your support. We handled the security issue on here: #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump axios to 0.34.0 — 0.33.0 is inside GHSA-x97p-jq2g-jp4f

3 participants