fix: remove hardcoded /Volumes/Workspace build-volume requirement - #212
Open
GQAdonis wants to merge 1 commit into
Open
fix: remove hardcoded /Volumes/Workspace build-volume requirement#212GQAdonis wants to merge 1 commit into
GQAdonis wants to merge 1 commit into
Conversation
AGENTS.md required every compiling Cargo command to set CARGO_TARGET_DIR beneath /Volumes/Workspace/crabbuild-target, and to stop rather than fall back to a local target/ when that volume was absent. That path is a macOS mount point specific to one contributor's machine, not a property of the project. On any checkout without it, an agent or contributor following AGENTS.md correctly concludes that no build, test, lint, or qualification step may be run at all. Two of the references were executable, not advisory: - scripts/qualify_compass_store_release.sh hard-failed with exit 1 unless /Volumes/Workspace was mounted and writable, making the compass-store release qualification gate unrunnable elsewhere; - both qualification scripts defaulted CARGO_TARGET_DIR to that absolute path, silently writing build output outside the checkout when the variable was unset. skills/compass-release/SKILL.md additionally listed the volume as a hard compatibility requirement and gated the release procedure on `test -d /Volumes/Workspace`. Replace the mandate with environment-neutral guidance that keeps the useful parts: per-checkout target directories, CARGO_TARGET_DIR not persisting between invocations, external qualification repositories treated as read-only, and cargo clean only with an explicit target directory. Scripts now honor CARGO_TARGET_DIR when set and otherwise fall back to the checkout's own target directory. Documentation uses <cargo-target-dir> and <qualification-corpus-root> placeholders. Introduced in dd14b3c ("docs: add AI contributor guidance"). Fixes crabbuild#211 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
Problem
AGENTS.mdrequired every compiling Cargo command to setCARGO_TARGET_DIRbeneath/Volumes/Workspace/crabbuild-target, and to stop rather than fall back to a localtarget/when that volume was absent./Volumes/Workspaceis a macOS mount point specific to one contributor's machine. It is not a property of the project, and there is no documented way to obtain or substitute it. On any checkout without that volume, an agent or contributor followingAGENTS.mdcorrectly concludes that no build, test, lint, or qualification step may be run at all.Because
AGENTS.mdis explicitly the operating guide for AI coding agents, and the rule is stated as a hard stop, this blocks agent-driven work outright — and agents that derive build commands from it propagate the path into their own generated configuration.Two references were executable, not advisory
scripts/qualify_compass_store_release.shhard-failed:Both qualification scripts silently redirected build output when
CARGO_TARGET_DIRwas unset:skills/compass-release/SKILL.mdalso listed the volume as a hard compatibility requirement and gated the release procedure ontest -d /Volumes/Workspace.Change
Replaces the mandate with environment-neutral guidance that keeps the parts that are genuinely about the project:
CARGO_TARGET_DIRdoes not persist between shell or tool invocations;cargo cleanonly with the intended target directory explicitly set.Scripts now honor
CARGO_TARGET_DIRwhen set and otherwise fall back to the checkout's owntarget/. Documentation uses<cargo-target-dir>and<qualification-corpus-root>placeholders.26 files, ~60 occurrences. Introduced in dd14b3c.
If the underlying concern is real
The original rule may have been protecting against disk pressure during large qualification runs. That intent is preserved as a recommendation rather than a hard requirement — a contributor who wants an external target directory sets
CARGO_TARGET_DIRand everything works as before. If you would prefer stronger wording pointing contributors toward an external volume for qualification specifically, I am happy to adjust.Verification
bash -npasses on both modified scripts./Volumes/Workspacereferences remain in the tree.I have not run the full qualification gates — they are long-running and this change does not alter their logic beyond the target-directory default and the removed mount check.
🤖 Generated with Claude Code