Skip to content

Fix #14452 fuzzing crash (null-pointer-use) in ReverseTraversal::traverse() #8723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

Fix #14452 fuzzing crash (null-pointer-use) in ReverseTraversal::traverse() #8723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05bd396
Update tokenlist.cpp
chrchr-github Jul 14, 2026
4869ae5
Create crash-85cab41781812453dfc8e74e1f0b915225f7a0a1
chrchr-github Jul 14, 2026
e1230e1
Update tokenlist.cpp
chrchr-github Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/tokenlist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1947,6 +1947,9 @@ void TokenList::validateAst(bool print) const
if ((tok->isAssignmentOp() || tok->isComparisonOp() || Token::Match(tok,"[|^/%]")) && tok->astOperand1() && !tok->astOperand2())
throw InternalError(tok, "Syntax Error: AST broken, binary operator has only one operand.", InternalError::AST);

if (!(tok->astOperand1() && tok->astOperand2()) && ((isC() && tok->str() == "&&") || Token::Match(tok, "%or%|%oror%")))
throw InternalError(tok, "Syntax Error: AST broken, binary operator is missing operand(s).", InternalError::AST);

// Syntax error if we encounter "?" with operand2 that is not ":"
if (tok->str() == "?") {
if (!tok->astOperand1() || !tok->astOperand2())
Expand Down
1 change: 1 addition & 0 deletions test/cli/fuzz-crash_c/crash-85cab41781812453dfc8e74e1f0b915225f7a0a1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
n(f=n){n&&,n}
Loading