Add unit tests for cppcheckdata.py#8707
Open
pfultz2 wants to merge 2 commits into
Open
Conversation
added 2 commits
July 8, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds unit tests for cppcheckdata.py which runs with pytest. It will also run these tests with cmake automatically if python is available, so this should run on the CI.
The unit tests did surface a couple of problems, but I didnt fix it this PR to keep the scope smaller. Instead I just marked the test with
pytest.mark.xfailfor now. I can do a follow up PR to fix these issues:Token.isBooleanis dead code.Tokenizer::dump(lib/tokenize.cpp:6179) checkstok->isName()beforeisBoolean(), andeBooleantokens count as names (lib/token.h:397), so true/false are always dumped astype="name"and thetype="boolean"branch at tokenize.cpp:6199 is unreachable for them(I see there isTODO: "true"/"false" aren't really a name...)Suppression.isMatch()(cppcheckdata.py:1007) doesn't check thatlineNumberis unset, so a suppression for line 5 also matches line 6. The fix would be a one-lineself.lineNumber is Noneguard.Token::Match,!!xalso matches when there is no token at all (null), but Pythonmatch()fails when the token list ends:match(last_brace, '} !!x')returns false.