Skip to content

chore: update filelock to 4.2.4 for its security fixes - #514

Merged
shenxianpeng merged 2 commits into
mainfrom
claude/project-thread-nfsfml
Oct 25, 2026
Merged

shenxianpeng merged 2 commits into
mainfrom
claude/project-thread-nfsfml

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Fixes the open Dependabot alerts for filelock (locked at 3.25.0). Dependabot can't open this update itself: the fixed releases (4.2.1+) need Python 3.11, while this project allows Python 3.10, so the resolver keeps picking 3.25.0.

filelock only comes in through pre-commit (pre-commit → virtualenv → filelock), which is a dev dependency. The fix is the same as cpp-linter/clang-tools-pip#241:

No effect on the action itself. The action installs --group action --no-dev, and uv export --group action --no-dev gives the same list before and after this change (clang-tools 2.0.0, cpp-linter 1.15.1, git-bot-feedback 0.3.0, pyyaml 6.0.3). The lock was written with a current uv, so it stays at revision = 5, and I checked that uv 0.9.5 (the version the action uses) accepts it with uv lock --check and syncs the action group on Python 3.10 and 3.12.

The only difference for contributors: on Python 3.10, uv sync no longer installs pre-commit. .python-version is 3.12.

Summary by CodeRabbit

  • Chores
    • pre-commit is now installed for development only with Python 3.11 or newer.
    • The spelling configuration now recognizes “filelock” as an accepted word. This keeps it from being flagged as a spelling error.

filelock 4.2.1+ needs Python 3.11, so pre-commit (which pulls in
filelock) is now only installed on Python 3.11 and newer. The action's
own dependency group is unchanged.
@shenxianpeng
shenxianpeng requested a review from a team as a code owner October 25, 2026 19:18
@shenxianpeng
shenxianpeng requested review from 2bndy5 and removed request for a team October 25, 2026 19:18
@shenxianpeng shenxianpeng self-assigned this Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.cpp
  • docs/examples/demo/demo.hpp
clang-tidy (v16.0.6) reports: 7 concern(s)

✨ Powered by cpp-linter -- ⭐ Star • ❤️ Sponsor • 💬 Feedback

@github-actions github-actions Bot added the bug Something isn't working label Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aeba8688-3cee-4ca9-8b43-5a7d9fddc392
Commits

Reviewing files that changed from the base of the PR and between d3a66b7 and c922a43.

Files selected for processing: 1
  • cspell.config.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

Walkthrough

The development dependency condition limits installation of pre-commit>=4.6.2 to Python 3.11 and later. The spelling configuration adds filelock to its accepted word list.

Changes

Development dependency

Layer / File(s) Summary
Gate pre-commit by Python version
pyproject.toml
The pre-commit requirement now applies only when Python is 3.11 or later.

Spelling configuration

Layer / File(s) Summary
Add filelock to accepted words
cspell.config.yml
The spelling configuration now accepts filelock.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: Minimal · up to c922a

The dependency update preserves Python 3.10 contributor and CI workflows while keeping filelock on supported Python versions.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the primary change: updating the locked filelock version to address security fixes. The supporting Python-version dependency change does not make the title misleading.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shenxianpeng shenxianpeng added maintenance Targets chores, refactors and cleanups and removed bug Something isn't working labels Oct 25, 2026
@shenxianpeng
shenxianpeng enabled auto-merge (squash) October 25, 2026 19:39
@shenxianpeng
shenxianpeng merged commit 774040a into main Oct 25, 2026
45 checks passed
@shenxianpeng
shenxianpeng deleted the claude/project-thread-nfsfml branch October 25, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Targets chores, refactors and cleanups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants