feat: exact rational DMS parsing and Degrees canonicalization#321
Open
yelliver wants to merge 1 commit into
Open
feat: exact rational DMS parsing and Degrees canonicalization#321yelliver wants to merge 1 commit into
yelliver wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(3600·d + 60·m + s) / 3600wrapped inDegrees.19/2°), not only integers.ce.number([totalSec, 3600])instead of a float sum, preserving exactness through the boxing pipeline.simplify().latexinstead of floating-point approximations.Motivation
DMS angles are naturally exact rationals of a degree:
9°30'is19/2°, not9.5as a float. The old pipeline aggregated components with floating-point arithmetic at parse time (deg + min/60 + sec/3600), which introduced rounding error before canonicalization.That mattered downstream:
Degreesonly had an exact rational→radian path for integer degrees. A parsed angle like5°37'30"became a float, missed the exact branch, and expressions such as converting to radians and simplifying could not reduce to clean fractions (e.g.π/32).This change keeps DMS exact end-to-end - parse as reduced rationals, box
DMS()the same way, and extendDegreescanonicalization to all rational arguments - so degree-to-radian conversion stays symbolically correct.