Repository navigation
Prepare chat.api 0.2.0 for CRAN - #29
Merged
Merged
Conversation
mx.client 0.3.0 ships without mx_call_join, mx_call_handle, and mx_call_leave, so chat_call_join(), chat_call_leave(), chat_call_media(), and chat_call_updates() have nothing to drive. They go, along with the calls capability flag, the calls element of chat_poll()'s result, the .call testing seam, and the call diagnostics in the crypto path. None of it reached CRAN. The code is kept on the livekitr-calls branch until livekitr is on CRAN. Encrypted edits and the guard that keeps bodiless decrypted events out of the message list stay.
The Suggests floors named development versions (mx.client 0.2.1.4, mx.crypto 0.2.2.2) that CRAN never carried. Both become 0.3.0, the releases that include encrypted attachment support, and the messages that tell a user what to install name the same versions.
matrix_decrypted_attachments() called setNames() without its namespace, which R CMD check reports as an undefined global. The encrypted markdown edit test called mx.client's renderer unguarded, so the tests errored where mx.client is absent. tools/check_tarball.sh now allows NEWS.md, which the package ships.
CRAN carries mx.api 0.4.0 and mx.crypto 0.3.0, so the drat and the pinned mx.crypto commit go. mx.client 0.3.0 is not on CRAN yet; it stays pinned to its release commit until it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the 0.2.0 CRAN update.
Changes
chat_call_join(),chat_call_leave(),chat_call_media(),chat_call_updates(), thecallscapability,$callsfromchat_poll(), and the.callseam ofchat_matrix(). mx.client 0.3.0 ships withoutmx_call_*. None of this reached CRAN; the code is kept onlivekitr-calls.setNames()inmatrix_decrypted_attachments()(check NOTE).cran-comments.mdfor the update.tools/check_tarball.shallowsNEWS.md.Verification
R CMD check --as-cran --run-donttest, Ubuntu 24.04.5, R 4.6.1, isolated library:Installed tests with an empty HOME left no files under it. CRAN lists no reverse dependencies.
Before submission
cran-comments.md.