Repository navigation
chat_set_identity() can set the account's picture - #27
Merged
Merged
Conversation
`avatar` is a path to an image, alongside `display`. Matrix uploads it and points the profile at it (testing seam `.avatar`); Slack, Telegram and IRC have no API for a bot's picture, so they ignore it and answer FALSE when it was all that was asked for. `chat_capabilities()$avatar` says which adapters set it. Both arguments are optional now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chat_set_identity(client, display = NULL, avatar = NULL):avataris a path to an image. Matrix uploads it and points the profile at it; Slack, Telegram and IRC have no API for a bot's picture, so they ignore it and answer FALSE when it was all that was asked for.chat_capabilities()$avatarsays which adapters set it. Both arguments are optional now, and asking for nothing is FALSE.Why: a consumer that sets its bot's picture at startup had to call
mx.api::mx_upload()andmx_set_avatar_url()itself, which puts a Matrix dependency back into code that otherwise speaks only chat.api.The testing seam
.avataronchat_matrix()stands for the upload-then-set pair.Checks: 1520 tests pass;
tinypkgr::check()0 errors, 0 warnings, 0 notes.