Remove org-wide labeling; it belongs to coreruleset only - #2
Open
fzipi wants to merge 1 commit into
Open
Conversation
Confirmed go-ftw, crs-toolchain, and plugin-registry already have labels with the exact same names our release/topic taxonomy uses (release:fix, release:ignore, release:new-feature, 📖 documentation), for unrelated purposes. The "missing label no-ops" assumption only protects against typos, not real collisions, so the org-wide config was mislabeling PRs in those repos. The schema has no per-repository scoping field, so labeling moves to a repo-local .coderabbit.yaml in coreruleset/coreruleset instead.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release:fix,release:ignore,release:new-feature, and:book: documentationfor unrelated purposes, so the org-widelabeling_instructionswas mislabeling PRs in those repos, not safely no-op-ingsuggested_labels,auto_apply_labels,labeling_instructions, andmutually_exclusive_groupsare removed from this org config.coderabbit.yamlin coreruleset/coreruleset (companion PR: coreruleset/coreruleset#TBD), which setsinheritance: trueto keep everything else from this org configslop_detection(theai-sloplabel) stays org-wide — no collision found across the org's reposTest plan
yamllint -d relaxed .coderabbit.yaml— only pre-existing line-length warningscheck-jsonschemaagainst the CodeRabbit schema — passesgh label listacross go-ftw, crs-toolchain, crs-linter, albedo, rassemble-go, plugin-registry, msc_pyparser, coraza-coreruleset confirmed the label-name collisions cited above