Skip to content

Center the sidebar avatar inside its loading ring - #703

Open
pratikbuilds wants to merge 1 commit into
corbitsdev:mainfrom
pratikbuilds:fix-sidebar-avatar-ring-alignment
Open

Center the sidebar avatar inside its loading ring#703
pratikbuilds wants to merge 1 commit into
corbitsdev:mainfrom
pratikbuilds:fix-sidebar-avatar-ring-alignment

Conversation

@pratikbuilds

Copy link
Copy Markdown
Contributor

The sidebar's working ring was centered on its container, but the inline avatar wrapper added baseline space below the avatar, pushing it upward. Make that wrapper a flex container so the avatar and ring share the same center and the gap stays even.

Before and after, rendered with the same Corbit avatar and built sidebar CSS at 2× scale. The browser-measured center offset is zero after the change.

Before: avatar above the ring center. After: avatar and loading ring share the same center.

Validation: full build, six sidebar tests, browser comparison, and bun run check.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, ship it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants