Harden mid-wait routable test against event-injection race - #699
Merged
Conversation
The mid-wait case used a fixed 10ms delay before injecting reply events. Under CI load the poll loop sometimes saw only 3 checks before those events settled the run early, failing `toBeGreaterThan(3)` even though the product path was fine. Gate routability behind an explicit flag, wait for ≥3 polls then the retried send, and only then inject replies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(sawReceived: 3twice on Fix New Agent drawer clipping and scrollbar overlap #691's post-rebase CI).Test plan
bun test packages/agent-directory/src/one-shot-prompt.test.ts(full file, 10/10)Follow-up to CL-7543 / #698.