Skip to content

fix(web): scope new-workbench opening message delivery to its tenant (#1116) - #1144

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-11063-web-ui-polish
Oct 21, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-11063-web-ui-polish

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Gate /new composer until the workbench list settles: Keep the /new composer disabled while workbenches.isPending is true (composerDisabled = selectedTenantId === null || workbenches.isPending) so the onboarding title/subtitle does not shift <Composer> mid-interaction, and trigger the send button via DOM .click() in startWorkbench (e2e/lib/first-run.ts).
  • Key <Workbench> by tenant and scope PendingOpeningMessage state (First message of a new workbench can be sent to the wrong workbench #1116): Pass key={workbenchTenantId} to <Workbench> in WorkbenchRoute and scope PendingOpeningMessage session state and mutation dispatch to the originating workbenchTenantId so switching workbenches never leaks or clears another workbench's opening message.

No user-facing docs needed updating because this is a bug fix to existing new-workbench creation and opening-message delivery behavior.

Closes #1116
Closes CL-11063

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

CL-11063

@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) October 21, 2026 04:28
@corbits-triage

corbits-triage Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve, request review.

Changed since the last verdict (Fail at 9286bd4): 12 new commits.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Focused: mixes unrelated changes

@TheGreatAxios
TheGreatAxios force-pushed the cl-11063-web-ui-polish branch from 9286bd4 to 6045972 Compare October 21, 2026 04:56
@TheGreatAxios TheGreatAxios changed the title fix(web): eliminate /new layout jump, key Workbench by tenant, and fix drawer avatar (#1110, #1116) fix(web): scope new-workbench opening message delivery to its tenant (#1116) Oct 21, 2026
@corbits-triage
corbits-triage Bot dismissed their stale review October 21, 2026 05:00

Nothing triage asked to change still fails, so this request no longer stands.

@TheGreatAxios
TheGreatAxios merged commit 6ace0ce into main Oct 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First message of a new workbench can be sent to the wrong workbench

1 participant