Skip to content

refactor(web): unify client-side agent and run status derivation - #1139

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-10994-unify-web-status-derivation
Oct 21, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-10994-unify-web-status-derivation

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-10994.

Summary

  • Consolidate run and routine status derivation (runOutcomeStatus, isRunActive, isRunFailed, routineState, routineRunTone, routineRunLabel, runStatusLabel) into apps/web/src/run-outcome.ts, and remove legacy ListingTurn, hasInFlightTurn, turns, and withListingAbandoned scaffolding left over from the deleted routines package.
  • Unify run event failure extraction (runFailureMessage, RunEventsSchema, insightsRunEventsPath) in apps/web/src/insights-api.ts across Insights, the bench drawer, and pages/routine-detail-page.tsx.
  • Consolidate deployment-level workerStatus and WorkerTone into apps/web/src/worker-status.ts alongside live turn/approval status derivation (useBenchWorkerStatus, useWorkerStatus).
  • Remove the dead shell/bench-activity.ts aggregator, unused listAgentDefinitions fetch, and orphaned tenantKeys entries in apps/web/src/query-client.ts.

@linear-code

linear-code Bot commented Oct 21, 2026

Copy link
Copy Markdown

CL-10994

@TheGreatAxios
TheGreatAxios enabled auto-merge (squash) October 21, 2026 04:28
@corbits-triage

corbits-triage Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Triage will approve, request review.

Changed since the last verdict (Fail at a48e9db): 12 new commits.

@corbits-triage corbits-triage Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • No merge conflicts: merge conflicts with base

@TheGreatAxios
TheGreatAxios force-pushed the cl-10994-unify-web-status-derivation branch from a48e9db to 65f7515 Compare October 21, 2026 05:01
@corbits-triage
corbits-triage Bot dismissed their stale review October 21, 2026 05:06

Nothing triage asked to change still fails, so this request no longer stands.

@TheGreatAxios
TheGreatAxios merged commit 2a1825e into main Oct 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant