Repository navigation
fix: animated-number restarts from the shown value; theme hydrates cleanly - #81
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9432
AnimatedNumber.
fromRefwas only updated when a count finished, so a newvaluearriving mid-count jumped back to the previous target before animating. Each frame now writes the interpolated number tofromRef, so the next count starts from what is on screen.ThemeProvider. The initial state read
localStorageandmatchMediaduring render, so a client with a stored preference or a dark OS rendered different text than the server and hydration failed. Preference now starts from thedefaultMode/defaultPresetfallback and system dark startsfalse, matching the server; the existing mount effects read storage andmatchMediaafterwards. The unusedreadSystemPrefersDarkhelper is removed.Tests: a value change mid-count continues from the displayed number (fake
requestAnimationFrame/performance.now);renderToStringthenhydrateRootwith a stored dark preference reports no recoverable errors and ends ondark/dark. Both fail on the previous code. No public API change.