Repository navigation
test(e2e): add approval, palette and theme browser specs - #68
Merged
TheGreatAxios merged 2 commits intoSep 27, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-9152-react-ui-add-e2e-for-approvalcard-approvereject-callbacks
branch
from
September 25, 2026 21:55
94e392a to
765d4da
Compare
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-9152-react-ui-add-e2e-for-approvalcard-approvereject-callbacks
branch
from
September 26, 2026 01:32
765d4da to
7ed965b
Compare
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-9152-react-ui-add-e2e-for-approvalcard-approvereject-callbacks
branch
from
September 27, 2026 19:08
7ed965b to
53f37b2
Compare
The palette has no Radix trigger, so Radix restored focus to nothing and it fell to the body.
TheGreatAxios
force-pushed
the
cl-9152-react-ui-add-e2e-for-approvalcard-approvereject-callbacks
branch
from
September 27, 2026 19:11
53f37b2 to
b4aaee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #67 (harness); merge that first.
Summary
state, both buttons are disabled and force-clicks fire nothing.CommandPalettenow records its opener and restores focus on close, because it has no Radix trigger to return to; with no opener captured, Radix's default is left alone..dark, and OS-dark emulation with no class, plusThemeToggleflipping light to dark. One baseline per state works on every OS.Verification
bun run check,bun run buildandbun run test:e2epass (9 Playwright tests). The focus-return spec fails without thecommand-palette.tsxfix.Closes CL-9152
Closes CL-9148
Closes CL-9144