Repository navigation
docs(readme): runnable-only Quickstart, one program (CL-8775) - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Quickstart now models workbench's apps/web integration instead of a toy example: install (npm/pnpm/yarn/bun, plus the git-SHA pin consumers use pre-release), the stylesheet import, mounting
ThemeProvider+Toasterat the app root (asapps/web/src/root.tsxdoes), and a page pattern pairingPageShell+EmptyState+Button(asapps/web/src/pages/not-found-page.tsxdoes). Removed the inventedSortableTable/Runsexample, which had no production consumer.Verification: all three tsx fences compile clean under
tsc --noEmit --strict(react-jsx, bundler resolution) against this repo's ownsrc/index.tstypes; zerodeclare/stubs/as anyin README.Fixes CL-8775