Repository navigation
Set Node 24 LTS as the minimum engine - #48
Conversation
ReviewVerdict: request changes. First CI in the repo; verify (24) is red (154 failures). engines.node >=24 is not the cause. Root cause is pre-existing: afterEach in use-controllable-state.test.ts and use-dismissable-popover.test.ts stubs console.error then delete console.error, which removes the method. Later files share the process. React act() warnings then throw TypeError: console.error is not a function. Tests run on Bun, not Node 24. setup-node does not execute the suite. Fix: restore console.error in those afterEachs (or mock.restore), pin bun in CI, run bun run build not only typecheck/lint/test. That harness fix is in flight on this branch. |
Re-reviewVerdict: approve pending GitHub CI. SHA e96bb00. console.error is restored after the stubbing tests (no more delete). Keeper asserts it is a function. bun test 338 pass locally. CI pins bun 1.4.0 and runs bun run build. Confirm verify (24) is green on Actions before merge. |
Declare engines.node >=24, cover Node 24 in CI, and state the floor in the README install section. No prior floor was declared.
delete console.error left later React act() warnings throwing TypeError. Pin bun 1.4.0 in CI and run bun run build as the generate+contrast gate.
55cb277 to
d512db8
Compare
Sets the Node floor to 24 LTS for CL-8550: engines.node >=24, CI matrix on Node 24, README install section states the floor. Prior state: no engines field declared. Verification: bun run typecheck, bun run lint, bun test (336 pass), npm pack --dry-run (exit 0; prepack full build produced dist/).