Repository navigation
Add Silk, Strata, and Echo thinking indicators - #40
Conversation
TheGreatAxios
left a comment
There was a problem hiding this comment.
Thanks for this — the three variants look great and the useId-keyed masks are the right call. Two things before merge:
- Hardcoded hexes in
thinking-mark.tsx.fill="#e98428"is light-mode--primary— under.dark,--primaryis#bf6b20, so the sweep paints the wrong orange in dark mode. Same forfill-[#77716a]/dark:fill-[#aaa39a]. House rule (ARCHITECTURE.md standing patterns):theme.cssis the only place a hex lives; components consume tokens (fill-primary, plus a token for the base gray). This is the same bug class the audit previously fixed inDitherCanvas. - No test. Every sibling PR ships one — even a
renderToStaticMarkupassert onrole="status",aria-hiddenon the mark, and the variant classes would cover the contract.
README section and the reduced-motion static frames in theme.css are good.
|
@TheGreatAxios The requested fixes are now in ebf13b2: the mark uses dark-aware theme tokens, and a focused rendering/accessibility test covers all variants. Could you re-review when you have a moment? |
ebf13b2 to
5ff5ac8
Compare
Review pass — maintainer fixes applied on top of
|

Adds reusable Corbits thinking indicators so apps can use the Silk horizontal sweep, Strata upward scan, or Echo waves through a
variantprop.ThinkingIndicatorpairs the animated mark with an accessible status label.ThinkingMarksupports standalone use with class-based sizing. Both support pause, preserve the shared logo geometry, and show a static highlight for reduced motion. Includes package exports, usage documentation, and Ladle stories.Validation:
bun run buildbun run typecheckbun run lintbun run dep-guardbun test: 336 passed, zero failuresClean-install validation passed using the npm tarball in two empty consumer projects: