Repository navigation
fix(policy): make focus checks advisory - #151
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onFail: labelto the existingfocusedrule in.corbits-triage.yml, making a focus finding advisory (flag/label) rather than a blocking failure.Evidence and scope
Related PR #147 has green CI but remains changes-requested in the focus-policy incident. This PR changes no code or reviews on #147 and does not dismiss any review. Tracking incident notes: CL-11825; this policy correction is not part of the observability-foundation scope.
Validation
git diff --checkpassed.checkPolicyFileaccepted the policy; exact-text comparison against the reviewed base confirmed the sole addition isonFail: labelon the focused rule.bun run checkpassed: typecheck, lint, formatting, and 852 tests (0 failures).Rollout and review
The live policy changes only after this PR merges into the default branch and affected PRs are reevaluated. Opening this PR does not change current triage behavior. Other checks and existing review requirements still apply; this does not guarantee approval or clear existing requested changes. Maintainer review and green required checks are still needed. Do not merge automatically.