Repository navigation
feat!: require React 19 - #149
Open
pratikbuilds wants to merge 1 commit into
Open
pratikbuilds wants to merge 1 commit into
pratikbuilds wants to merge 1 commit into
Conversation
Narrow the react and react-dom peer range to ^19.0.0 and drop the React 18 claims from the README. Many components take `ref` as a plain prop, which only reaches them on React 19. Resolves corbitsdev#142 finding 20. BREAKING CHANGE: the react and react-dom peer range no longer accepts React 18; consumers must be on React 19.
TheGreatAxios
requested changes
Oct 30, 2026
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Review · Request changes
Narrows the react and react-dom peer dependency range to ^19.0.0 and removes React 18 support claims from README.md and Panel's JSDoc.
Findings
CONTRIBUTING.md:37— Peer and dependency range changes usebuild(deps):with no!("Add!only for public API breaks: removed or renamed exports, changed signatures, newly required params. Peer and dependency range changes arebuild(deps):with no!."). Could we retitle the commit and PR fromfeat!: require React 19tobuild(deps): require React 19?src/ui/panel.tsx:30— This commit removes"on React 18 and 19"fromPanel's JSDoc at line 90, but leavesHIDDEN_PANE_PROPS: Record<string, string> = { inert: "inert" }(lines 30–34 and 423) in the same file, which exists only because React 18 dropped booleaninert. Under React 19,PanelPanecan passinert={!shown}directly on the<div>and removeHIDDEN_PANE_PROPS.src/ui/conversation.tsx:969(informational) —ConversationItemstill keeps areleaseref fallback and comment for React 18'snull-ref detach alongside the React 19 cleanup return (andsrc/ui/conversation.test.tsx:312,src/ui/attachments.test.tsx:137,src/ui/message.test.tsx:557,src/ui/prompt-input.test.tsx:133still carry React 18forwardRefcomments).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrows the
reactandreact-dompeer range to^19.0.0and drops the React 18 claims from the README and thePaneldocs (finding 20). Many components takerefas a plain prop, which only reaches them on React 19.Breaking: consumers must be on React 19.
Verification
bun run checkbun.lockis updated to the new peer range.Closes #142