Repository navigation
fix(panel): restore the committed width and keep focus on pane switch - #147
Open
pratikbuilds wants to merge 1 commit into
Open
pratikbuilds wants to merge 1 commit into
pratikbuilds wants to merge 1 commit into
Conversation
A drag that ends without a release (a new press on the handle, or the hook unmounting) now drops the preview and puts back the committed `--resizable-width`, so CSS and controlled state cannot diverge. The drop moves from `commit` into the drag's teardown, which every end path runs. Pointercancel and lost capture still commit the preview, as before. Hiding a keep-mounted pane that holds focus now moves focus to the panel before the browser applies `inert`, instead of letting it fall to the page. Addresses corbitsdev#142 findings 15 and 16.
Contributor
|
Triage: Fail @pratikbuilds, please address the following:
Triage will request changes. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Not Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in
useResizableandPanelContent(findings 15 and 16).--resizable-width, so the CSS width and controlled state cannot diverge. The reset moves fromcommitinto the drag's teardown, which every end path runs. Pointercancel and lost capture still commit the preview.keepMountedpane that holds focus moves focus to the panel before the browser appliesinert, instead of letting it fall to the page.Not in scope: without
keepMounted, the hidden pane unmounts and focus still falls to the page. That behaviour is unchanged frommain.Verification
bun run checkbun run test:e2e, with the new pane-switch case ine2e/panel.spec.ts(the notes fixture gains an "Open draft" button to focus)use-resizable.test.tsCloses #142