Repository navigation
fix(chat): keep focus and counts honest in message parts and activity - #146
Open
pratikbuilds wants to merge 1 commit into
Open
pratikbuilds wants to merge 1 commit into
pratikbuilds wants to merge 1 commit into
Conversation
Addresses findings 1, 10 and 11 of corbitsdev#142. - 1, MessageParts: focus leaving for the page or outside now also clears the deferred decision watch, so a later `parts` update that records the decision no longer pulls focus back to the run's trigger. The window losing focus to another tab or window keeps the watch, so a decision recorded meanwhile still hands focus to the run. - 10, ToolGroup: the live "done" count leaves out failed calls, so active, waiting, done and failed no longer overlap in the `running` or `held` header (e.g. "Running 3 at once · 1 done · 1 failed"). - 11, ActivityContent: when a new step slides the step holding focus behind the latest-ten window, focus moves to the "Show N earlier steps" control instead of falling to the page.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
conventions: check
and removed
Triage: Waiting for CI
labels
TheGreatAxios
approved these changes
Oct 30, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Review · Approve
Clears the deferred decision focus watch in MessageParts when focus leaves for the page or outside while the document retains focus, excludes failed tool calls from the live done count in ToolGroup, and moves focus to the "Show N earlier steps" control in ActivityContent when streaming steps push the focused step out of the ten-step window.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focus and count fixes in
MessageParts,ToolGroupandActivityContent(findings 1, 10 and 11).partsupdate that records the decision no longer pulls focus back to the run's trigger. The window losing focus to another tab or window (!document.hasFocus()) keeps the watch, so a decision recorded meanwhile still hands focus to the run.donecount leaves out failed calls, so active, waiting, done and failed no longer overlap in therunningandheldheaders (e.g. "Running 3 at once · 1 done · 1 failed").Verification
bun run checkbunx playwright testfor the message-parts, tool and activity specsmessage-parts.test.tsx,tool.test.tsxandactivity.test.tsxCloses #142