Repository navigation
feat(web): edit a repository's policy from a code review page - #675
Closed
Conversation
List each repository's rules from its policy file and open one pull request through the existing patch route.
A rule the file does not list is not previewed until the batch enables it and sets max or paths.
Contributor
Author
|
Review: needs fixes, and one part is the wrong direction. It also sits on an old #672 commit (lacks 6ffa01a), so turning on
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch is based on
cl-11575-add-a-server-route-that-patches-a-repositorys-policy-filebecause the page calls the policy patch route from that pull request. It does not add a second route.A policy file is
.corbits-triage.ymlon a repository's default branch. It decides which rules run, including judging and code review (bug finding). The Code Review page lists those rules for one repository and opens one pull request for a batch of changes.POST /api/integrations/github-triage/{tenantId}/policy/patch.text(the claim), it passes when that claim is true, and what happens on fail isonFail.Verification
bun run checkpassed (typecheck and hub bundle).bun run lintpassed: 22 warnings, 0 errors, exit 0.bun --conditions=intx-src test --preload ./apps/web/src/lib/dom-preload.ts ./apps/web/src/components/code-review/PolicyEditor.dom.test.tsxpassed: a switch becomes a tray change and the preview shows the file before and after.git log --format='%G? %ae' -1printsG.Closes CL-11564