Skip to content

fix(manager): read the mail step's reply when waiting for the judge or code review - #638

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11532-read-the-mail-steps-reply-when-the-manager-waits-for-the
Oct 26, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11532-read-the-mail-steps-reply-when-the-manager-waits-for-the

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Closes CL-11532

Why

On a real sidecar, an agent step's output is an object holding the reply text and the assistant turn, not the bare text. The manager's check of whether its mail to the judge or the code review went out expected text, so the pass crashed and the pull request was labelled "Unsure, decision model unavailable".

What changed

  • The manager reads the reply text from the judge's and the code review's mail steps, and then parses whether the mail went from it as before.
  • The triage-manager tests now answer agent steps in the shape a live sidecar uses ({ reply, turn }).

No docs changed: they describe what the manager does, and that has not changed.

Verified

  • bun --conditions=intx-src test packages/triage-manager packages/triage-judge: 45 pass. With the live output shape, 7 manager tests fail on main and pass with this change.
  • bun run check, bun run lint and the policy check against origin/main are clean.

…r code review

A live agent step outputs { reply, turn }, so judgeMailed and reviewMailed read the reply text before parsing whether the mail went.
@linear-code

linear-code Bot commented Oct 26, 2026

Copy link
Copy Markdown

CL-11532

@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 26, 2026 18:53
@TheGreatAxios
TheGreatAxios merged commit 3032163 into main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant