Repository navigation
fix(hub): show the manager's code review in the portal - #636
Merged
TheGreatAxios merged 2 commits intoOct 26, 2026
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-11529-show-the-managers-code-review-in-the-portal
branch
from
October 26, 2026 18:11
d11d149 to
da371e0
Compare
TheGreatAxios
force-pushed
the
cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the
branch
from
October 26, 2026 18:23
642ecfb to
02da276
Compare
TheGreatAxios
force-pushed
the
cl-11529-show-the-managers-code-review-in-the-portal
branch
from
October 26, 2026 18:23
da371e0 to
cc64d5e
Compare
TheGreatAxios
force-pushed
the
cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the
branch
2 times, most recently
from
October 26, 2026 18:54
276da80 to
da19b71
Compare
TheGreatAxios
force-pushed
the
cl-11529-show-the-managers-code-review-in-the-portal
branch
from
October 26, 2026 18:57
cc64d5e to
daea947
Compare
TheGreatAxios
force-pushed
the
cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the
branch
from
October 26, 2026 19:22
da19b71 to
79c9094
Compare
TheGreatAxios
force-pushed
the
cl-11529-show-the-managers-code-review-in-the-portal
branch
from
October 26, 2026 19:22
daea947 to
828b17a
Compare
TheGreatAxios
changed the base branch from
cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the
to
main
October 26, 2026 20:00
TheGreatAxios
marked this pull request as ready for review
October 26, 2026 20:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-11529
Why
The portal's code review section showed only reviews from the old standalone code review workflow. Reviews a pull request's manager ran were posted to the pull request but never appeared in the portal.
What changed
Verified
code-review-runs.postgres.test.tsto cover: no review; a finished review; a failed one; one the manager gave up on; a running one; a result no pass took, which is ignored; the review going to the right host; carrying a review over by its diff hash; and the throttle that stops a failed host read from being retried on every poll. 1 of 1 passes. The old code fails it, because it does not read the manager's records.report.test.tschecks that a review reports its diff's hash.bun run check,bun run lintand the policy check pass.