Skip to content

fix(hub): show the manager's code review in the portal - #636

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-11529-show-the-managers-code-review-in-the-portal
Oct 26, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-11529-show-the-managers-code-review-in-the-portal

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Closes CL-11529

Why
The portal's code review section showed only reviews from the old standalone code review workflow. Reviews a pull request's manager ran were posted to the pull request but never appeared in the portal.

What changed

  • The code review section, and Send to GitHub or Bitbucket, now read the manager's records on both hosts. They show the newest of three things: a review the manager deployed that is still running, the result a review reported, or a review the manager gave up on, such as one past its deadline. Only results one of the manager's passes took, or that come from a review the manager deployed, count. A pull request with none of these shows the same empty state as before.
  • A review that did not finish shows only "The last review did not finish", with no reason underneath. The unused failure-reason helper is removed, and the user manual sentence is updated.
  • A finished review now reports the hash of the diff it read, so a later commit with the same diff still takes that review over.
  • The old standalone reviews are no longer read, so they stop appearing in the portal from this PR until the CL-11525 removal slice deletes the old review feed. The whole stack merges together.
  • ARCHITECTURE.md and IMPLEMENTATION.md describe where reviews are read from.

Verified

  • Rewrote code-review-runs.postgres.test.ts to cover: no review; a finished review; a failed one; one the manager gave up on; a running one; a result no pass took, which is ignored; the review going to the right host; carrying a review over by its diff hash; and the throttle that stops a failed host read from being retried on every poll. 1 of 1 passes. The old code fails it, because it does not read the manager's records.
  • report.test.ts checks that a review reports its diff's hash.
  • Hub code review, manager state, server, pr-code-review, triage-manager and triage-contracts tests: 357 of 357 pass.
  • bun run check, bun run lint and the policy check pass.

@linear-code

linear-code Bot commented Oct 26, 2026

Copy link
Copy Markdown

CL-11529

@TheGreatAxios
TheGreatAxios force-pushed the cl-11529-show-the-managers-code-review-in-the-portal branch from d11d149 to da371e0 Compare October 26, 2026 18:11
@TheGreatAxios
TheGreatAxios force-pushed the cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the branch from 642ecfb to 02da276 Compare October 26, 2026 18:23
@TheGreatAxios
TheGreatAxios force-pushed the cl-11529-show-the-managers-code-review-in-the-portal branch from da371e0 to cc64d5e Compare October 26, 2026 18:23
@TheGreatAxios
TheGreatAxios force-pushed the cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the branch 2 times, most recently from 276da80 to da19b71 Compare October 26, 2026 18:54
@TheGreatAxios
TheGreatAxios force-pushed the cl-11529-show-the-managers-code-review-in-the-portal branch from cc64d5e to daea947 Compare October 26, 2026 18:57
@TheGreatAxios
TheGreatAxios force-pushed the cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the branch from da19b71 to 79c9094 Compare October 26, 2026 19:22
@TheGreatAxios
TheGreatAxios force-pushed the cl-11529-show-the-managers-code-review-in-the-portal branch from daea947 to 828b17a Compare October 26, 2026 19:22
@TheGreatAxios
TheGreatAxios changed the base branch from cl-11526-run-catch-up-triage-again-and-the-settings-status-from-the to main October 26, 2026 20:00
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 26, 2026 20:00
@TheGreatAxios
TheGreatAxios merged commit e4e05fa into main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant