Repository navigation
feat: rename the jev constructor to systemOne - #29
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Stacked on #28: only this pull request's own changes were checked. Waiting on a maintainer to approve: approve, request review. |
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 27, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Review · Approve
Renames the jev constructor to systemOne and keeps jev as an alias of the same function.
Findings
No findings.
src/jev.ts defines systemOne and exports it as jev. The barrel re-exports both. src/workflow.ts imports systemOne. No jev( call sites remain. jev === systemOne, and bad thresholds still throw. bun install --frozen-lockfile exited 0.
Merged
Contributor
Author
Contributor
Author
|
Superseded by the 0.2.0 release: #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jevtosystemOne.jevexported as the same function.judgeModelis unchanged.Verification
bun run checkexited 0 (2 unit tests, 72 e2e tests).21f0601found no defects.Stacked on #28.
Fixes CL-11515