Repository navigation
feat: add string includes and prebuilt judge scorers - #26
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
|
Triage: Fail @TheGreatAxios, please address the following:
Stacked on #25: only this pull request's own changes were checked. |
TheGreatAxios
commented
Oct 27, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Review · Approve
Adds includes and the prebuilt judge scorers as one workflow step.
Findings
No findings.
includes reads expectedOutput. Graded judges fail closed on partial credit and extra keys. Each prebuilt is one judge step with input: { from: "trigger.payload" }. includes is exported from the package root. faithfulness, answerRelevancy, correctness, trajectoryAccuracy, and parsePrebuilt are exported from the workflow entry. bun test e2e/prebuilt.e2e.test.ts plus a deleted probe exited 0 (8 pass).
Merged
Contributor
Author
Contributor
Author
|
Superseded by the 0.2.0 release: #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includes, a string check: case-insensitive substring after NFKC, trim, and whitespace collapse. An empty needle fails closed.faithfulness,answerRelevancy,correctness, andtrajectoryAccuracyas one-step workflow factories, exported only from@corbits/evals/workflow.parsePrebuiltrejects fenced or out-of-range judge output instead of clamping it.Verification
bun run checkexited 0 (typecheck, oxlint, oxfmt, unit tests, 60 e2e tests).2f46622found no defects.Stacked on #25.
Fixes CL-11498