Skip to content

Report lexicon by name on skill_used #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheGreatAxios wants to merge 1 commit into from
Closed

Report lexicon by name on skill_used #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/TELEMETRY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ director ids from `DIRECTOR_IDS` (and the legacy `worker` alias) are reported
by id; project-defined or marketplace profile ids become `custom`.
`skill_used` carries `skill_name`: a first-party skill name reportable by
name from the closed `corbits-skills` allowlist (`ast-grep`, `create-issue`,
`git-rebase`, `git-worktrees`, `implement`, `interview`,
`git-rebase`, `git-worktrees`, `implement`, `interview`, `lexicon`,
`linear-issue-workflow`, `opsh`, `philosophy`, `plan`,
`pull-request-review`, `refactor`, `review`, `scribe`, `style`,
`typescript`), or `custom` for anything else. `user-invocable: false` opts a
Expand Down
1 change: 1 addition & 0 deletions src/telemetry/classify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ const FIRST_PARTY_SKILL_NAMES: ReadonlySet<string> = new Set([
"git-worktrees",
"implement",
"interview",
"lexicon",
"linear-issue-workflow",
"opsh",
"philosophy",
Expand Down
1 change: 1 addition & 0 deletions tests/unit/telemetry-product-events.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ test("first-party skill names are reported by name; everything else stays custom
"git-worktrees",
"implement",
"interview",
"lexicon",
"linear-issue-workflow",
"opsh",
"philosophy",
Expand Down
Loading